Further portability fixes (hopefully the last) #18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Printing error messages to stderr makes testing more complex
because it is hard to portably redirect stderr and stdout
is not synchronized with stderr.
So it is much easier just to use stdout.
Note that we expect most users to override the definitions
of ASL_{runtime_error,assert,error} and they may use
stderr in their own versions if they choose.
We resolved the portability issues by writing all error output to stdout - which avoids the need to try to redirect stderr to a pipe.
alastairreid
force-pushed
the
areid-fix-osx-more
branch
3 times, most recently
from
3717b86 to
c5b6ab8
Compare
alastairreid
force-pushed
the
areid-fix-osx-more
branch
from
c5b6ab8 to
0c98706
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
asis emulated by clang (because we need full GNU as macro support)