Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aggiunta sezione Tools e modificato sezione 'tecniche dei test' #197

Merged
merged 7 commits into from
Jan 27, 2024

Conversation

mariomontella
Copy link
Contributor

Piccola prima modifica. Aggiornatemi!

docs/it/testing.md Outdated Show resolved Hide resolved
docs/it/testing.md Outdated Show resolved Hide resolved
docs/it/testing.md Outdated Show resolved Hide resolved
Copy link
Member

@Cadienvan Cadienvan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mi piace molto l'accrescimento che hai dato alle varie aree del capitolo, veramente un lavoro ben fatto!

Mi sono permesso di suggerire qualche aggiustamento di forma e ho aggiunto un "disclaimer" agli strumenti di testing non volendo rischiare di far passare il messaggio sbagliato. Se ti torna, facciamo fare una review anche al resto del team Ambassador!

@mariomontella
Copy link
Contributor Author

Sisi va benissimo. Ho visto le modifiche. Tranquillo errori miei ahahah

@Cadienvan
Copy link
Member

Ciao @mariomontella ,
come d'accordo ho apportato le modifiche, attendo solo il lancio del formatter così poi chiediamo la review!

@Cadienvan
Copy link
Member

@Il-Libro-Open-Source/tech-group c'è anche Prettier aggiornato ma lo vedo come un non problema, che ne pensate?

Cadienvan
Cadienvan previously approved these changes Jan 20, 2024
docs/it/testing.md Outdated Show resolved Hide resolved
docs/it/testing.md Outdated Show resolved Hide resolved
EMCestari
EMCestari previously approved these changes Jan 20, 2024
Copy link
Member

@EMCestari EMCestari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approvato con commenti per typo minori

@mariomontella mariomontella dismissed stale reviews from EMCestari and Cadienvan via 9e1d88c January 20, 2024 13:04
Cadienvan
Cadienvan previously approved these changes Jan 20, 2024
@Cadienvan Cadienvan requested a review from EMCestari January 20, 2024 13:35
EMCestari
EMCestari previously approved these changes Jan 20, 2024
Copy link
Contributor

@allevo allevo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao! mi sembra tutto ok.
L'unica cosa che mi viene in mente di sottolineare sono i tool di test non agnostici dal linguaggio poiché mi chiedo se non vale la pena coordinare l'intero libro sulla scelta di questi 2 linguaggi come esempi in modo da non averne di diversi nei capitoli, che potrebbe confondere il lettore.

BrianAtzori
BrianAtzori previously approved these changes Jan 24, 2024
Copy link
Member

@BrianAtzori BrianAtzori left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ciao, per me le aggiunte sono ok, non ho trovato errori e concenttualmente mi sembra tutto ok

docs/it/testing.md Outdated Show resolved Hide resolved
sensorario
sensorario previously approved these changes Jan 25, 2024
@Cadienvan Cadienvan dismissed stale reviews from sensorario, BrianAtzori, corradopetrelli, EMCestari, and themself via 0784217 January 27, 2024 08:58
@Cadienvan Cadienvan merged commit 2d9411b into Il-Libro-Open-Source:main Jan 27, 2024
1 check passed
Cadienvan added a commit that referenced this pull request Feb 10, 2024
…dei test' (#197)

Co-authored-by: Michael Di Prisco <[email protected]>
Co-authored-by: Michael Di Prisco <[email protected]>
Co-authored-by: Simone Gentili <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants