Removed 'compare' functions and other unnecessary bits #10
Conversation
|
Awesome, I will review and test this shortly! |
| * @param {Number} c weak | ||
| * @param {Number} [w] weight | ||
| * @return {Number} strength | ||
| * @param a strong |
There was a problem hiding this comment.
Just curious, why remove the jsdoc type annotations?
There was a problem hiding this comment.
Reason is that the types are already present as TypeScript argument annotations. But I don't feel strongly about this at all. What happened is that my lint tool called this out as an unnecessary redundancy, and it sounded like a reasonable change to me.
(FWIW, use of jsdoc is pretty inconsistent across this codebase. I would be happy to follow whatever guidelines people want.)
|
Hey, I'm the guy who pushed #8 and made that code obsolete. Yeah, this totally makes sense. My initial push intentionally didn't change any code beyond maptype.ts -- I was changing enough in @IjzerenHein 's code already so preserved the code that called into The old map used an associative array internally, and the supplied |
|
Thanks for taking a look, @adamhaile! (And for #8 too.) |
|
How do you think this looks, @IjzerenHein? |
Per #9. Thanks!