[WIP] Rewrite based on NamedDimsArrays #1608
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1608 +/- ##
==========================================
+ Coverage 77.61% 85.00% +7.38%
==========================================
Files 69 1 -68
Lines 5222 20 -5202
==========================================
- Hits 4053 17 -4036
+ Misses 1169 3 -1166
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Closing in favor of ITensor/ITensorBase.jl#1. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrite based on
NamedDimsArrays.jl.In the new design, the
ITensortype is a subtype ofNamedDimsArrays.AbstractNamedDimsArraywith an associated dimension name object (theIndexName, which contains the metadata for theIndextype which stores the name and range of values of the dimension).Most of the actual implementation will be in
NamedDimsArrays.jl,BlockSparseArrays.jl,TensorAlgebra.jl, etc.