Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format testset names #42

Merged
merged 2 commits into from
Jan 14, 2025
Merged

Format testset names #42

merged 2 commits into from
Jan 14, 2025

Conversation

lkdvos
Copy link
Collaborator

@lkdvos lkdvos commented Jan 14, 2025

This assigns testsets to just the group + filename instead of the full path:
(example from SparseArraysBase)
Before:

Test Summary:                                                         | Pass  Total  Time
/Users/ldevos/Projects/SparseArraysBase.jl/test/basics/test_basics.jl |  240    240  2.7s
Test Summary:                                                           | Pass  Total  Time
/Users/ldevos/Projects/SparseArraysBase.jl/test/basics/test_diagonal.jl |   24     24  0.3s
Test Summary:                                                          | Pass  Total  Time
/Users/ldevos/Projects/SparseArraysBase.jl/test/basics/test_exports.jl |    1      1  0.1s

After

     Testing Running tests...
Test Summary:          | Pass  Total  Time
/basics/test_basics.jl |  240    240  2.7s
Test Summary:            | Pass  Total  Time
/basics/test_diagonal.jl |   24     24  0.3s
Test Summary:           | Pass  Total  Time
/basics/test_exports.jl |    1      1  0.1s

Copy link

codecov bot commented Jan 14, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 6.02%. Comparing base (88679b0) to head (8aa09b8).

Additional details and impacted files
@@          Coverage Diff          @@
##            main     #42   +/-   ##
=====================================
  Coverage   6.02%   6.02%           
=====================================
  Files          1       1           
  Lines         83      83           
=====================================
  Hits           5       5           
  Misses        78      78           
Flag Coverage Δ
docs 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lkdvos lkdvos requested a review from mtfishman January 14, 2025 13:04
@mtfishman
Copy link
Member

Looks reasonable, definitely easier to read. The reason I liked having the absolute path was because I could see if tests of the dev'd package vs. the undev'd package were being run but in the end I don't think I needed that and it isn't worth the extra noise, and I think you can get that information from the output of Pkg.test anyway.

As a nitpick, I would prefer basics/test_exports.jl over /basics/test_exports.jl to make it clear it is a relative path rather than an absolute path.

This assigns testsets to just the group + filename instead of the full
path
@lkdvos
Copy link
Collaborator Author

lkdvos commented Jan 14, 2025

I fully agree, I changed the implementation slightly such that this should now be the case

@mtfishman
Copy link
Member

Looks good, thanks. Can you bump the version then I'll merge?

@lkdvos lkdvos merged commit 07dd797 into ITensor:main Jan 14, 2025
@lkdvos lkdvos deleted the ld-testsetnames branch January 14, 2025 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants