This repository has been archived by the owner on Jan 20, 2025. It is now read-only.
Add support for expanding singleton dimensions #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Broadcasting in Julia supports expanding singleton dimensions to match a common size. Before this PR, when converting broadcasting expressions like:
to map expressions, we didn't handle repeating over the singleton dimensions properly. This PR fixes that by creating map expressions that lazily repeat the smaller arrays using a combination of
FillArrays.Fill
andBlockArrays.BlockArray
.This PR also refactors some of the internals to hopefully make the logic a little clearer.