Benchmark/nbody #21
Merged
Benchmark/nbody #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
fixes #9 |
IR0NSIGHT
force-pushed
the
benchmark/nbody
branch
from
d8ab9f0 to
1d904e8
Compare
IR0NSIGHT
force-pushed
the
benchmark/nbody
branch
from
e71b9f2 to
f65ae72
Compare
Closed
phischu
approved these changes
Nov 30, 2023
| def offsetMomentum(px: Double, py: Double, pz: Double, body: Body) = { | ||
| Body( | ||
| body.x, body.y, body.z, | ||
| 0.0 -(px / SOLAR_MASS), |
There was a problem hiding this comment.
We should add a definition def neg(x: Double): Double to the standard library. Likewise for the bitshift operations you've added in another benchmark. Perhaps you could make a pull request on the effekt repo?
Co-authored-by: phischu <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.