-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new dataset changes #224
base: develop
Are you sure you want to change the base?
new dataset changes #224
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, but we need a couple of things:
a. Use your code to implement ExampleAnalysis in order to have a sense of how the code would be instantiated.
b. Pass the PEP8 verifier to make sure the formatting is adequate.
Yes, I was thinking of implementing it somewhere so we can understand what changes can be made. Just have one question. |
For the PEP8, how to do that? I didn't understand what you meant by "Pass the PEP8 verifier". Did you mean to give PEP8 verifier object? or to pass the PEP8 formatting test successfully? |
Apologies for the unclear explanation. I should have said "pass the PEP8 formatting test correctly". |
Oh, okay so is there a command I can run to format it correctly? because my pycharm doesn't auto format for some reason. I tried using the pep8 config file. |
This draft PR introduces a new Dataset class with new read and write methods to hide the underlying mechanism of reading and writing datasets and modularizes the Input/Output Classes. I have left TODO's where we still need to discuss validation mechanisms.