CoDICE: Calculate epoch values from acq_start_seconds instead of shcoarse #1262
Conversation
bourque
added
Ins: CoDICE
imap_processing/codice/codice_l1a.py
Outdated
| epoch : NDArray[int] | ||
| List of epoch values. | ||
| """ | ||
| epoch = met_to_j2000ns(self.dataset.acq_start_seconds) |
There was a problem hiding this comment.
Just to double check... acq_start_seconds records the spacecraft clock coarse ticks (seconds) at acquisition start time and there is no sub-seconds field? If both of those things are true, this looks like the correct implementation to me.
There was a problem hiding this comment.
After discussing with Joey, there is indeed a sub-seconds field that I will have to implement, so I will update that. acq_start_seconds does indeed record the S/C clock coarse ticks at acquisition time.
There was a problem hiding this comment.
@subagonsouth Could you give this another look any make sure I am thinking about this correctly? It is a bit tricky since acq_start_seconds is in units of seconds and acq_start_subseconds is in units of microseconds, so I think I need to do a small conversion before calculating epoch.
Change Summary
Overview
This PR adds a function to calculate epoch values from
acq_start_secondsfield instead of the defaultshcoarsefield, as per request from CoDICE instrument team. The function may also be expanded in the future to support other time keys if needed.Updated Files
imap_processing/codice/codice_l1a.py