UI: move UI\Component\Table\Storage up to UI\Storage #8818
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thibsy
requested changes
Jan 14, 2025
There was a problem hiding this comment.
Hi @nhaagen,
Thanks a lot for your contribution to the UI components!
Please consider the following suggestions. You do not need to follow them, but please indicate shortly why you prefer to do otherwise:
- Interface description: while we are at it, could you also provide a brief interface description, which describes the nature of this storage? this way, other components and also implementors will know, how they need to treat values stored in this object.
nhaagen
force-pushed
the
11/UI/StorageInterface
branch
from
3a34d54 to
cc84c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storage is quiet generic; as discussed, I'll move it up some levels so other Components will use it, too.