Fix duplicate global roles for FILTER_ALL

and eliminate duplicate declare strict_types
ILIAS-eLearning · Jan 15, 2025 · 811cb48 · 811cb48
1 parent 0cb2dd4
commit 811cb48
Showing 1 changed file with 1 addition and 3 deletions.
diff --git a/Services/AccessControl/classes/class.ilRbacReview.php b/Services/AccessControl/classes/class.ilRbacReview.php
@@ -18,8 +18,6 @@
 
 declare(strict_types=1);
 
-declare(strict_types=1);
-
 /**
  * class ilRbacReview
  *  Contains Review functions of core Rbac.
@@ -857,7 +855,7 @@ public function getRolesByFilter(int $a_filter = 0, int $a_user_id = 0, string $
             // all (assignable) roles
             case self::FILTER_ALL:
                 yield from $this->getAssignableRolesGenerator(true, true, $title_filter);
-
+                return;
                 // all (assignable) global roles
                 // no break
             case self::FILTER_ALL_GLOBAL: