Skip to content

Commit

Permalink
Removed todos from help component
Browse files Browse the repository at this point in the history
  • Loading branch information
Dexagod committed Oct 5, 2020
1 parent 8fc40c8 commit ff9f70f
Show file tree
Hide file tree
Showing 2 changed files with 23 additions and 70 deletions.
50 changes: 0 additions & 50 deletions src/Components/HelpComponent.js
Original file line number Diff line number Diff line change
Expand Up @@ -116,57 +116,7 @@ const HelpComponent = (props) => {
</Col>
</Row>
<br />

<div >
<p><b>TODOS</b></p>
<p>Delete (read) notifications</p>
<p>Have notification actions fire on receive and not on looking at specific view</p>
<p>Mark notifications as read</p>
<p>Highlight hovered notification</p>
<p>Only load notifications that were not load last time</p>

<p>Update civil status on certification (of both spouses, possibly via a notification)</p>


<p>Encryption and signing for accepting invitation and for certificate</p>

<p>Check if login is to a valid pod (profile file exists and inbox exists</p>
<p>Finish implementation delete mariage proposal</p>
<p>Make all contracts visible for all actors involved</p>
<p>What to do with the official? Allow it to be anyone and give input field?</p>
<p>More error handling for missing data fields in files</p>
<p>Unify internal naming scheme: proposal and certificate</p>
<p>Provide delete proposal for intermediary steps</p>
<p>Propagate deletion to all notified people who have already accepted / ... Maybe not remove but jsut flag as dead?</p>

<p>Is it okay to use this demo vocabulary?</p>
<p>What to do with default storage locations?</p>
<p>Use Solid file clients to recursively create folders if a specified storage location does not yet exist?</p>
<p>JSDoc all functions</p>
<p>convert components to have logic for data retrieval somewhere else?</p>

</div>




set all created data to a specific name and provide delete button at the end to remove all demo data (except for name?) so that if people use their real data pod it wont get that messy?

SET LEFT BAR SELECTED ITEM HIGHLIGHT

set other key items in lists in case of duplicate subjects

code comments

convert large components - save additional logic in a controller file?

<br />
This screen will provide information on how the steps for this demo, and how they can be performed (with images preferably)
I also would like to make this not a single page app, so I can link people to the help page (or even make this the landing screen)
But I have not yet worked with the routing options for react, but that would be a nice to have
<br />
</div>

)
}

Expand Down
43 changes: 23 additions & 20 deletions src/Components/MiniDrawer.js
Original file line number Diff line number Diff line change
Expand Up @@ -105,15 +105,30 @@ const MiniDrawer = withWebId((props) => {
const isActive = (item) => item.id === activeDrawerItemMapping[selectedView.id]

const getSidebarComponent = (itemName, index) => {
if (itemName === 'divider') return (<Divider key={index}/>)
if (itemName === 'br') return (<br key={index}/>)
const item = availableViews[itemName]
return (
<ListItem button={true} className={isActive(item) ? 'active' : 'nonactive'} button key={index} onClick={ () => setSelectedView(item)}>
<ListItemIcon>{item.icon}</ListItemIcon>
<ListItemText primary={item.label} />
</ListItem>
)
switch (itemName) {
case 'divider':
return (<Divider key={index}/>)
case 'br':
return (<br key={index}/>)
case 'help':
return (
<Link to="/help" target="_blank" style={{ textDecoration: 'none', color: "black" }}>
<ListItem button={true} className={isActive(item) ? 'active' : 'nonactive'} button key={index}>
<ListItemIcon>{item.icon}</ListItemIcon>
<ListItemText primary={item.label} />
</ListItem>
</Link>
)
default:
if (!item) return <div />
return (
<ListItem button={true} className={isActive(item) ? 'active' : 'nonactive'} button key={index} onClick={() => setSelectedView(item)}>
<ListItemIcon>{item.icon}</ListItemIcon>
<ListItemText primary={item.label} />
</ListItem>
)
}
}

// const openApp = () => { if(window.location.endsWith('help')) window.open(window.location)
Expand Down Expand Up @@ -152,18 +167,6 @@ const MiniDrawer = withWebId((props) => {
</MenuItem>
)
}
return (
<MenuItem className={className} onClick={() => setSelectedView(item)} key={index}>
<IconButton aria-label={item.label} color="inherit">
{itemName === 'notifications'
? <Badge badgeContent={notifications.length} color="secondary">
{item.icon}
</Badge>
: item.icon
}
</IconButton>
</MenuItem>
)
}

const sideBarItems = props.sideBarItems || ['profile', 'requests', 'running', 'certificates', 'divider', 'br', 'divider', 'official', 'divider']
Expand Down

0 comments on commit ff9f70f

Please sign in to comment.