-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Activating Pyomo linear presolve for IDAES models #1415
Conversation
…into scaling_v2
* Resolve CI failures from new version (1.20.4) of spellchecker (IDAES#1389) * Empty commit to verify failures on main * Resolve likely false positives * Resolve likely true positives * Resolve probable true positive * Remove "frst" from typos exclusions * Remove "ans" from typos exclusions b/c crate-ci/typos#981 * Fix target for 'fv' (flowsheet visualizer) reference (IDAES#1391) * outputs * fix hyperlink * put this back * put this back2 * replace with simple hyperlink * Updating black and rerunning it on all files (IDAES#1388) * Updating black and rerunning it on all files * Remove duplicated Black requirement * Update Black rev in pre-commit config --------- Co-authored-by: Ludovico Bianchi <[email protected]> --------- Co-authored-by: Ludovico Bianchi <[email protected]> Co-authored-by: Dan Gunter <[email protected]> Co-authored-by: Keith Beattie <[email protected]>
@andrewlee94 The TSA tests pass for me when I set |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
==========================================
- Coverage 77.80% 77.68% -0.12%
==========================================
Files 393 393
Lines 64797 64837 +40
Branches 14390 14404 +14
==========================================
- Hits 50413 50368 -45
- Misses 11794 11855 +61
- Partials 2590 2614 +24 ☔ View full report in Codecov by Sentry. |
Closing in favour of #1436. This PR tried to do too much at once and ran into backward compatibility issues. |
Fixes None
Summary/Motivation:
This PR builds on previous work to bring the new Pyomo solver interfaces into IDAES and activates the use of the new linear presolver.
All core code (
core
andmodels
) has been updated to use the presolver, however many parts ofmodels_extra
have issues relating to the pre-solver.TSA models: linear presolve results in an "invalid value in AMPL evaluation" exception during initialization. Presovle has been disabled.
Tray column and associated models show at least two different initialization failures. Given the current state of these model, this should be addressed by a complete overhaul of the tray column code. Presolve has been disabled.
Gas-Solid Contactors: BFB and FB01 have issues with presolve. Disabled presolve.
Power Generation:
Changes proposed in this PR:
Legal Acknowledgement
By contributing to this software project, I agree to the following terms and conditions for my contribution: