Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New petabjl syntax #1131

Merged
merged 12 commits into from
Oct 19, 2023
Merged

New petabjl syntax #1131

merged 12 commits into from
Oct 19, 2023

Conversation

PaulJonasJost
Copy link
Collaborator

new example taken from here

@codecov-commenter
Copy link

codecov-commenter commented Oct 10, 2023

Codecov Report

Merging #1131 (641f56a) into develop (a52ae70) will decrease coverage by 1.23%.
The diff coverage is 0.00%.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

@@             Coverage Diff             @@
##           develop    #1131      +/-   ##
===========================================
- Coverage    83.02%   81.79%   -1.23%     
===========================================
  Files          148      148              
  Lines        11642    11642              
===========================================
- Hits          9666     9523     -143     
- Misses        1976     2119     +143     
Files Coverage Δ
pypesto/objective/julia/petabJl.py 0.00% <0.00%> (ø)
pypesto/objective/julia/petab_jl_importer.py 0.00% <0.00%> (ø)

... and 10 files with indirect coverage changes

@PaulJonasJost PaulJonasJost mentioned this pull request Oct 11, 2023
@PaulJonasJost PaulJonasJost marked this pull request as ready for review October 11, 2023 16:09
@PaulJonasJost PaulJonasJost requested a review from a team as a code owner October 11, 2023 16:09
@PaulJonasJost PaulJonasJost self-assigned this Oct 11, 2023
@PaulJonasJost PaulJonasJost requested a review from Doresic October 11, 2023 16:11
Copy link

@sebapersson sebapersson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very minor comments. I will also try to fix the API doc in PEtab.jl to make it easy for anyone to see all the options.

doc/example/conversion_reaction/PEtabJl_module.jl Outdated Show resolved Hide resolved
doc/example/conversion_reaction/PEtabJl_module.jl Outdated Show resolved Hide resolved
Copy link
Contributor

@Doresic Doresic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, a better naming scheme than before.

@PaulJonasJost PaulJonasJost merged commit 520b718 into develop Oct 19, 2023
17 checks passed
@PaulJonasJost PaulJonasJost deleted the new_petabjl_syntax branch October 19, 2023 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants