-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor plot_n_important_coeffs, unexport others #68
Conversation
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #68 +/- ##
==========================================
- Coverage 79.93% 79.90% -0.04%
==========================================
Files 16 16
Lines 648 652 +4
==========================================
+ Hits 518 521 +3
- Misses 130 131 +1 ☔ View full report in Codecov by Sentry. |
About
|
For
|
…needed to be sequential. Also fixed previous bug with n=NULL as dim instead of length had to be used. Added tests for those situations.
There's an issue with latest Posit Package Manager sync with CRAN. Tests are fine. Merging. |
Partial work towards #56.
So far, I've refactored the
plot_n_important_coeffs
just as ann2poly
plot method, and put that together withpredict
. We still need totidytext
. It's weird to have that package in suggests just for those two small things.Please, address this in this branch while I think a little bit more about the other plot functions.