Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

telegram-cli: Add Apple Silicon support by supporting the --sysconfdi… #80245

Closed
wants to merge 1 commit into from

Conversation

areese
Copy link
Contributor

@areese areese commented Jun 29, 2021

…r option of configure

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

This one is a little odd:

The upstream fix is here:
vysheng/tg#1714

However, it doesn't apply cleanly, so attached one in the data section.

I need to look again, as I think there is a way to do this when building against HEAD, I'll have to look at other formula and come back

@BrewTestBot BrewTestBot added deprecated license Formula uses a deprecated SPDX license which should be updated no ARM bottle Formula has no ARM bottle labels Jun 29, 2021
@nandahkrishna nandahkrishna added the CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. label Jun 29, 2021
@areese
Copy link
Contributor Author

areese commented Jun 29, 2021

I figured it out what to do, but the telegram-cli upstream source doesn't build.

@SMillerDev
Copy link
Member

Last commit is from 2016, I think we can at least deprecate this since the author does not seem to be working on the project anymore.

@areese
Copy link
Contributor Author

areese commented Jun 30, 2021

@SMillerDev would you like me to add a deprecated flag?
I'm trying to ensure as many packages build on m1 as possible, and upstreaming the commits if possible.
This one has installs, but prob should be deprecated as upstream doesn't built at all.

@SMillerDev
Copy link
Member

Yeah, that's my preference

@areese
Copy link
Contributor Author

areese commented Jun 30, 2021

ok adding it, wanted to check

@areese areese force-pushed the m1-support/telegram-cli branch from c5b275a to 5d16b12 Compare June 30, 2021 20:33
@BrewTestBot BrewTestBot added the formula deprecated Formula deprecated label Jun 30, 2021
@areese
Copy link
Contributor Author

areese commented Jun 30, 2021

@SMillerDev I used:

+  # "This project is deprecated and is no longer being maintained.
+  # Last commit was in 2016
+  deprecate! date: "2021-06-01", because: :unmaintained
+

bah wrong date.

@areese
Copy link
Contributor Author

areese commented Jun 30, 2021

fixed

@areese areese force-pushed the m1-support/telegram-cli branch from 5d16b12 to 7d7dd3d Compare June 30, 2021 20:34
@carlocab carlocab closed this in c51ca56 Jul 4, 2021
@carlocab
Copy link
Member

carlocab commented Jul 4, 2021

Merged in c51ca56. Will dispatch an ARM bottle separately.

@areese areese deleted the m1-support/telegram-cli branch July 6, 2021 15:22
@github-actions github-actions bot added the outdated PR was locked due to age label Aug 6, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
CI-force-arm [DEPRECATED] Don't pass --skip-unbottled-arm to brew test-bot. deprecated license Formula uses a deprecated SPDX license which should be updated formula deprecated Formula deprecated no ARM bottle Formula has no ARM bottle outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants