Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codebase clean up #19

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Codebase clean up #19

wants to merge 1 commit into from

Conversation

wycliffkas
Copy link
Contributor

@wycliffkas wycliffkas commented Feb 22, 2021

Overview πŸš€

Refactor and also introducing using environment variables for sensitive data

Type of change πŸ§™β€

  • ✨ New feature (area): code base cleanup.

How Has This Been Tested? 🚨

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • βœ… Manual testing

Checklist βœ…

  • [βœ… ] My code follows the style guidelines of this project

  • [βœ…] I have performed a self-review of my own code

@wycliffkas wycliffkas changed the title ode base clean up Codebase clean up Feb 22, 2021
@wycliffkas wycliffkas force-pushed the feature/codebase-clean-up branch from cd6a738 to 0c00d46 Compare February 22, 2021 13:14
@wycliffkas wycliffkas requested a review from sor2 February 22, 2021 17:26
Copy link
Collaborator

@sor2 sor2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't seem to compile for me. At first glance, it might have something to do with the map component being deleted. Please take another look at this

@silenteyesoncode
Copy link
Member

when you guys are planning to merge this?

@silenteyesoncode silenteyesoncode linked an issue Jun 9, 2021 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants