Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing commit for (m)atk/(m)def percent implementation and one official behavior fix for BS_OVERTHRUST #3293

Merged
merged 2 commits into from
May 2, 2024
+14 −2
Merged

Add missing commit for (m)atk/(m)def percent implementation and one official behavior fix for BS_OVERTHRUST #3293

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5842dd2
Initialze atk%, def% etc to 100 for all bl types
skyleo Jul 12, 2021
53e0ee4
Implement official ATK % calculation for BS_OVERTHRUST in pre-renewal
skyleo Mar 17, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 14 additions & 2 deletions src/map/status.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3884,6 +3884,11 @@ static void status_calc_misc(struct block_list *bl, struct status_data *st, int
st->mdef2 += st->int_ + (st->vit >> 1);
#endif // RENEWAL

st->atk_percent = 100;
st->matk_percent = 100;
st->def_percent = 100;
st->mdef_percent = 100;

if ( bl->type&battle_config.enable_critical )
st->cri += 10 + (st->luk * 10 / 3); // (every 1 luk = +0.33 critical -> 3 luk = +1 critical)
else
Expand Down Expand Up @@ -8303,8 +8308,15 @@ static int status_change_start_sub(struct block_list *src, struct block_list *bl
val2 = 20*val1; //Power increase
break;
case SC_OVERTHRUST:
//val2 holds if it was casted on self, or is bonus received from others
val3 = 5*val1; //Power increase
#ifndef RENEWAL
if (val2 == 1) // cast on self
val3 = 5 * val1; //Power increase
else // received cast
val3 = 5;
#else
// for renewal this is actually wrong for party members since 2020 and will need to be changed.
val3 = 5 * val1; // Power increase
#endif
if(sd && pc->checkskill(sd,BS_HILTBINDING)>0)
total_tick += total_tick / 10;
break;
Expand Down
Loading