Fix all aCalloc calls that had their parameters in the wrong order #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gcc-14 validates the order of parameters in calloc, so giving proper names for each of them makes easier to tell what should go in each one. it should always be (number of element, size of each element) or gcc 14 will give warnings. other macros were adjusted where size/number also applied to keep the name standard
aCalloc should be called with (number of elements, size of each element) or gcc 14 will warn.
ghost
approved these changes
Feb 10, 2024
4144
approved these changes
Feb 11, 2024
MishimaHaruna
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Prelude
Changes Proposed
Since gcc-14 began running in our CI, we had been having random failures in
aCallocdue to wrong order of parameters. For some reason, fixing one place doesn't necessarily triggers the error to the other one...In this PR I looked through every place we use
aCallocand fixed the order to match the function expectations:(number of elements, size of each element). While using in the reverse order works for the language, it fails in gcc-14 validation.I also renamed the macro parameters to be num / size instead of m/n (which always makes me ask what each one is supposed to receive).
Issues addressed:
None, I think