Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate dictionaries #163

Merged
merged 4 commits into from
Jan 8, 2025
Merged

fix: validate dictionaries #163

merged 4 commits into from
Jan 8, 2025

Conversation

kayman-mk
Copy link
Member

@kayman-mk kayman-mk commented Jan 8, 2025

Description

  • use correct path to validation script
  • do not continue on failed jobs, we don't see the error as the job is green
  • clean the workflow dictionary. It should contain the unknown words for the copied workflows only. Otherwise an error is shown in the validation of the related projects.

Verification

Locally verified.

@kayman-mk kayman-mk requested a review from a team as a code owner January 8, 2025 16:18
Copy link

github-actions bot commented Jan 8, 2025

Hey @kayman-mk! 👋

Thank you for your contribution to the project. Please refer to the
contribution rules for a quick overview of the process.

Make sure that this PR clearly explains:

  • the problem being solved
  • the best way a reviewer and you can test your changes

With submitting this PR you confirm that you hold the rights of the code added and agree that it will
published under this LICENSE.

The following ChatOps commands are supported:

  • /help: notifies a maintainer to help you out
  • /ready: marks the PR as ready for review and removes the checklist

Simply add a comment with the command in the first line. If you need to pass more information, separate it
with a blank line from the command.

This message was generated automatically. You are welcome to
improve it.

@kayman-mk kayman-mk merged commit 88fe732 into main Jan 8, 2025
14 checks passed
@kayman-mk kayman-mk deleted the kayma/fix-spell branch January 8, 2025 16:25
@HapagLloydTechnicalUser
Copy link

🎉 This PR is included in version 1.6.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants