Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Riven 2024, Radio Free D'ni, ExpEmp, and Mysterium 2024 Clothing #260

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

DoobesURU
Copy link
Contributor

  • Add Riven 2024 shirt and sources (dpogue)
  • Add Radio Free D'ni shirt (long and short sleeve) and sources (AlanD, et al.)
  • Add Explorers' Emporium reward tunic and sources (Semjay)
  • Add Mysterium 2024 shirt and sources (Doobes)
  • Update Fan02 and Mysterium JSON files with new clothing definitions

@dpogue
Copy link
Member

dpogue commented Sep 24, 2024

Just realized this is going to be missing the 3Ds Max file change that I had to make for the [Fe]Male04 files for the pub jacket... I'll see if I can extract those into their own commit

* Add Riven 2024 shirt and sources (dpogue)
* Add Radio Free D'ni shirt and sources (AlanD, et al.)
* Add Explorers' Emporium reward shirt and sources (Semjay)
* Add Mysterium 2024 shirt and sources (Doobes)
* Update Fan02 and Mysterium JSON files with new clothing defintions
This is needed to support selecting between the existing Pub jacket and
the ExpEmp reward jacket.
@dpogue
Copy link
Member

dpogue commented Sep 24, 2024

This should have everything now

@Hoikas
Copy link
Member

Hoikas commented Nov 3, 2024

@dpogue Are these PRPs current and not affected by the low/high time problem?

@dpogue
Copy link
Member

dpogue commented Nov 3, 2024

I think the 04 PRP files here are bad, I'll push a commit with the ones that I submitted to OU (which seemed to work during testing)

@DoobesURU
Copy link
Contributor Author

I think the 04 PRP files here are bad, I'll push a commit with the ones that I submitted to OU (which seemed to work during testing)

Yes, please do. I haven't had a chance to fix them as of late, and if you've already got working copies... 😊

The previous ones had duplicated textures due to a bug in the 3DS Max
exporter, and apparently those caused weird client bugs as well.
@dpogue
Copy link
Member

dpogue commented Nov 3, 2024

Okay, I think this should be good now.

@Hoikas
Copy link
Member

Hoikas commented Nov 3, 2024

It looks like this will conflict with #266. I'm inclined to merge that first, then I'm assuming we'll just need to re-roundtrip the PRPs to resolve the conflicts?

@dpogue
Copy link
Member

dpogue commented Nov 3, 2024

yes, with the caveat that there is a specific order in which things need to be round-tripped unless we update the Fan02 and Mysterium JSON files to include the page references for everything

@Hoikas
Copy link
Member

Hoikas commented Nov 3, 2024

I'll give this one a glance once the female PRP updated

@Hoikas Hoikas added global Applies generally or to all Ages awaiting author This pull request or issue is blocked on a response or revision from the author. conflict This pull request modifies binary files in a way that conflicts with history or other pull requests and removed awaiting author This pull request or issue is blocked on a response or revision from the author. labels Nov 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conflict This pull request modifies binary files in a way that conflicts with history or other pull requests global Applies generally or to all Ages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants