Update to Linking Book Mod share function #335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deledrius
previously approved these changes
Jun 25, 2022
Hoikas
reviewed
Jun 25, 2022
korman/properties/modifiers/gui.py
Outdated
| @@ -482,7 +482,7 @@ def pre_export(self, exporter, bo): | |||
| else: | |||
| rgn_obj = self.clickable_region | |||
|
|
|||
| if self.shareable: | |||
| if self.shareable and self.link_type == "kOriginalBook": | |||
There was a problem hiding this comment.
To reduce the amount of potentially duplicated logic, Korman usually has Python properties for this. Eg, in the class:
@property
def export_share_region(self) -> bool:
return self.shareable and self.link_type == "kOriginalBook"Then this line becomes:
Suggested change
| if self.shareable and self.link_type == "kOriginalBook": | |
| if self.export_share_region: |
Deledrius
reviewed
Jun 29, 2022
DoobesURU
force-pushed
the
LinkBookModShareV2
branch
from
d8b2cdc to
3fe6a23
Compare
Hoikas
reviewed
Jun 29, 2022
Comment on lines
+691
to
+700
| # Odds and Ends | ||
| stamped = nodes.new("PlasmaAttribBoolNode") | ||
| stamped.link_output(linkingnode, "pfm", "IsDRCStamped") | ||
| if not self.drc_stamp: | ||
| stamped.value = False | ||
| forcecam = nodes.new("PlasmaAttribBoolNode") | ||
| forcecam.link_output(linkingnode, "pfm", "ForceThirdPerson") | ||
| if self.third_person: | ||
| forcecam.value = True | ||
|
|
There was a problem hiding this comment.
I'm thinking we should defer these changes to another PR.
Sets the default of the share to false as the default along with an extra check before making a share region. This keeps extra, unneeded share regions from being added.
Adds bool values for the stamp and third person cam portions of the xLinkingBookGUIPopup.py parts of the script (MOUL only)
Make the new bool nodes actually work when selected
DoobesURU
force-pushed
the
LinkBookModShareV2
branch
from
3fe6a23 to
357bd8c
Compare
Updated the stamped property to better reflect its purpose (it's for any stamp on the left page, not just the DRC)
Add new @Property per Hoikas' suggestion
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sets the default of the share function to false along with an extra check before creating a default share region. This ensures extra, unneeded share regions will not be added as is happening with the current setup (per Ehren's examination of the Chiso files).