Remove dead/server-only network protocol code #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The server side probably needs this so it can look up the right protocol for each incoming connection, but the client always knows which protocol it's using and so doesn't need a global registry. This reduces the amount of bookkeeping needed in pnNetCli without requiring much more work in plNetGameLib.
There's no difference between the "raw" and non-"raw" types. "ptr" is the same as "data", but unused and not fully implemented.
NET_MSG_FIELD_QWORD and NET_MSG_FIELD_DOUBLE cannot be sent reliably, because NetCliSend receives all message arguments as uintptr_t, which for 32-bit builds isn't large enough to hold 64-bit values. NET_MSG_FIELD_FLOAT is technically fine, but passing it the expected way through a uintptr_t requires some very counterintuitive casting. All the corresponding _ARRAY types are mostly fine as well, because multi-element arrays are passed by pointer, which by definition always fits into uintptr_t. I'm removing these field types as well though, because they're potentially error-prone, aren't currently used anywhere, and are unlikely to ever be used in the future (because the low-level network protocol will never change and is very unlikely to be extended).
Hoikas
approved these changes
Jan 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This drops various bits of code under pnNetCli that are unused and very unlikely to ever be useful, namely:
As usual, the commit messages for the non-obvious changes have more detailed reasoning.