Dynamically checking display depth for Mac client #1542
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hoikas
reviewed
Dec 15, 2023
Comment on lines
+299
to
+318
| if (window) | ||
| { | ||
| NSDictionary<NSDeviceDescriptionKey, id> *windowProperties = [window deviceDescription]; | ||
| NSUInteger bitsPerPixel = [windowProperties[NSDeviceBitsPerSample] unsignedIntValue]; | ||
| #if PLASMA_PIPELINE_METAL | ||
| if (bitsPerPixel <=8) | ||
| { | ||
| if (self.metalLayer.pixelFormat != MTLPixelFormatBGRA8Unorm) | ||
| { | ||
| self.metalLayer.pixelFormat = MTLPixelFormatBGRA8Unorm; | ||
| } | ||
| } else { | ||
| if (self.metalLayer.pixelFormat != MTLPixelFormatBGR10A2Unorm) | ||
| { | ||
| self.metalLayer.pixelFormat = MTLPixelFormatBGR10A2Unorm; | ||
| } | ||
| } | ||
| #endif | ||
| } | ||
| } |
There was a problem hiding this comment.
Is this the correct brace newline style?
|
I'm going to close this. I've seen some Apple samples even default to 16 bit color without checking the monitor modes. So I don't think this is a serious performance concern. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Hoikas - This is a possible optimization for older GPUs.
I'm not happy about the approach - the way this is implemented is promoting the color depth of the entire window instead of just the Metal output. I'd like to figure out if there is a better way to do this - so I'm leaving this as a draft until the implementation and the potential improvements are better understood.