Modernize NucleusLib async callbacks using lambdas #1539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In preparation for the next change to how AsyncSocket makes callbacks.
This significantly simplifies the argument passing to the callbacks and makes it clearer which callbacks are called where.
Not that it really matters - TransferRef is a no-op aside from debug log messages...
There are very few message types and they're all statically defined, so the dispatch table isn't really useful here.
Hoikas
reviewed
Dec 13, 2023
Sources/Plasma/PubUtilLib/plNetGameLib/Private/plNglGateKeeper.cpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Johnson <[email protected]>
Hoikas
approved these changes
Dec 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to improve the "callback hell" in the low-/middle-level network code. The AsyncCore APIs relied heavily on C-style callback functions with untyped
void*context parameters, which made it difficult to follow the execution and data flow in NetGameLib.This PR migrates almost all of the async callbacks to use
std::function(where they didn't already) and the callers to use lambdas for capturing context variables. This obsoletes thevoid*parameters and removes lots of manual casts.AsyncSocket is a special case: its callback function was really multiple distinct callbacks wrapped in a generic signature, so I replaced it with a "callbacks object" with multiple virtual methods that the caller has to implement. This is a very "Java-ish" solution and is incompatible with lambdas, but works well with how the AsyncSocket API is used. It also clarifies the different callbacks' signatures and helps with seeing where each one is called.
The PR diff for the NetGameLib files is a bit noisy, because I changed some functions to instance methods and had to rename a couple of fields. The individual commit diffs are more readable there (e34454c is the noisy refactor).