Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump vcpkg to 2023.11.20 #1529

Merged
merged 1 commit into from
Nov 27, 2023
Merged

Bump vcpkg to 2023.11.20 #1529

merged 1 commit into from
Nov 27, 2023

Conversation

dpogue
Copy link
Member

@dpogue dpogue commented Nov 22, 2023

Also fix the Windows Python build after doing so.

Updated Dependencies

  • asio
    1.28.0#1 -> 1.28.2

  • curl
    8.2.1 -> 8.4.0

  • fontconfig
    2.14.2 -> 2.14.2#1

  • freetype
    2.12.1#3 -> 2.12.1#4

  • libjpeg-turbo
    2.1.5.1#2 -> 3.0.1

  • libvpx
    1.12.0#1 -> 1.13.1

  • python3
    3.10.7#8 -> 3.10.7#9
    Just a config change to fix Windows linking with the newer version of libffi in vcpkg.

  • zlib
    1.2.13 -> 1.3

@dpogue
Copy link
Member Author

dpogue commented Nov 22, 2023

Weird that macOS fontconfig is failing here, because this branch built successfully in my fork... I'll try to investigate further 😕

Also fix the Windows Python build after doing so.
@dpogue
Copy link
Member Author

dpogue commented Nov 24, 2023

This should be good to go now

@Hoikas
Copy link
Member

Hoikas commented Nov 25, 2023

distutils was removed in Python 3.12....

@dpogue
Copy link
Member Author

dpogue commented Nov 25, 2023

distutils was removed in Python 3.12....

yeah, and it looks like the macOS runners are updated to Python 3.12, but something in fontconfig's build process requires it 😕

@Hoikas
Copy link
Member

Hoikas commented Nov 25, 2023

Should probably use actions/setup-python to force Python 3.11

@Hoikas
Copy link
Member

Hoikas commented Nov 25, 2023

Well, that seems to have broken the Linux build. Fantastic. I guess installing the setuptools package from pip will be ok.

@dpogue
Copy link
Member Author

dpogue commented Nov 25, 2023

setup-python is probably doing something to inject itself forcefully into the path, and then interfering with finding the vcpkg python 🤦🏼‍♂️

@Hoikas
Copy link
Member

Hoikas commented Nov 25, 2023

Probably so. That's arguably a vcpkg bug (or a bug in the python3 port) because vcpkg is supposed to insulate itself from the environment. <_<

@Hoikas Hoikas merged commit 45bc9b7 into H-uru:master Nov 27, 2023
34 checks passed
@dpogue dpogue deleted the vcpkg-2023.11.20 branch December 2, 2023 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants