Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Brazilian Portuguese Translation #397

Closed

Conversation

clr-cera
Copy link
Contributor

@clr-cera clr-cera commented Nov 2, 2023

🇧🇷 Brazilian Portuguese Translation

This PR translates Sniffnet to brazilian portuguese.

Although european portuguese and brazilian portuguese are very similar, they differ in several ways and what "feels good" in one may not be the same in the other.

Translation of both translations and translations_2 files to Brazilian Portuguese
Initial update of language.rs to fit Brazilian Portuguese Language.
@GyulyVGC
Copy link
Owner

GyulyVGC commented Nov 2, 2023

I thank you a lot for your contribution, but we already had a discussion about this topic as a PR for Brazilian Portuguese was submitted in #134 and one for European Portuguese was submitted in #136.

In particular, this was the response by @franciscoBSalgueiro who submitted the European version:

It's the same language, so any portuguese speaking person would be able to read both. That being said, you can definitely tell one was written by a Brazilian and another by a Portuguese. I've seen some apps have both a pt_PT and pt_BR translation, but if you only want to have one, I think any of them would work.

And from that I decided to only include the European version for reasons of easier maintainability.

What do you think?

@GyulyVGC GyulyVGC added the translation User interface translation label Nov 2, 2023
@clr-cera
Copy link
Contributor Author

clr-cera commented Nov 2, 2023

Oh sorry, I haven't seen those PRs!

However as a Brazilian I do think they differ in relevant ways, one sure could read both translations, but there are several different words and habits between them! There are some Portuguese ways of speaking that although are 100% comprehensible, in Brazil they would be unusual or sometimes even wrong.

I saw that European Portuguese is not updated to translations_2.rs, and I don't feel able to complete it as I don't speak this variation of the language and as a consequence would be heavily biased.

In the other hand your decision is completely understandable for practicality and I should indeed have searched for PRs about this.

@GyulyVGC
Copy link
Owner

GyulyVGC commented Nov 2, 2023

Don't worry!
Given your considerations, I think I'll include your translation as well.
Even if it will add the overhead of managing one more language, it can be a valuable addition for native Brazilians.

@GyulyVGC GyulyVGC added this to the v1.3.0 milestone Nov 3, 2023
@GyulyVGC
Copy link
Owner

GyulyVGC commented Nov 3, 2023

Hey @clr-cera I was about to merge the PR but I noticed that the changes with respect to the European variant are minimal.
At this point I think it's better to only keep one language.
Would you like to open a new PR just to update the original PT translation? (i.e., including only translations_2.rs from this PR)

@GyulyVGC GyulyVGC removed this from the v1.3.0 milestone Nov 3, 2023
@clr-cera
Copy link
Contributor Author

clr-cera commented Nov 4, 2023

Sure! I will close this PR and soon I'll send a new one, at the end there will be an European and Brazilian portuguese mix, which I don't think is inherently bad either.

@clr-cera clr-cera closed this Nov 4, 2023
@clr-cera clr-cera deleted the Brazilian-Portuguese-Translation branch November 4, 2023 23:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translation User interface translation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants