-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Brazilian Portuguese Translation #397
Conversation
Translation of both translations and translations_2 files to Brazilian Portuguese
Initial update of language.rs to fit Brazilian Portuguese Language.
I thank you a lot for your contribution, but we already had a discussion about this topic as a PR for Brazilian Portuguese was submitted in #134 and one for European Portuguese was submitted in #136. In particular, this was the response by @franciscoBSalgueiro who submitted the European version:
And from that I decided to only include the European version for reasons of easier maintainability. What do you think? |
Oh sorry, I haven't seen those PRs! However as a Brazilian I do think they differ in relevant ways, one sure could read both translations, but there are several different words and habits between them! There are some Portuguese ways of speaking that although are 100% comprehensible, in Brazil they would be unusual or sometimes even wrong. I saw that European Portuguese is not updated to translations_2.rs, and I don't feel able to complete it as I don't speak this variation of the language and as a consequence would be heavily biased. In the other hand your decision is completely understandable for practicality and I should indeed have searched for PRs about this. |
Don't worry! |
Hey @clr-cera I was about to merge the PR but I noticed that the changes with respect to the European variant are minimal. |
Sure! I will close this PR and soon I'll send a new one, at the end there will be an European and Brazilian portuguese mix, which I don't think is inherently bad either. |
🇧🇷 Brazilian Portuguese Translation
This PR translates Sniffnet to brazilian portuguese.
Although european portuguese and brazilian portuguese are very similar, they differ in several ways and what "feels good" in one may not be the same in the other.