Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wolf final #28

Open
wants to merge 237 commits into
base: addRCUT
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
237 commits
Select commit Hold shift + click to select a range
a60fc40
first push
Sep 22, 2021
dda48c9
merged wolf and targetswap changes to config setup
Sep 22, 2021
74686ed
fix SwapCorrection continue term by adding an abs, also differentiate…
Sep 22, 2021
623f20e
add metamake and config setup
Sep 22, 2021
44e4de1
pass wolf boolean to GPU kernels
Oct 12, 2021
d177da9
Push
Oct 12, 2021
a94da95
Energy and FFParticle on GPU done.
Oct 13, 2021
7c8505f
Pass to all the diff functions in En
Oct 13, 2021
aad9e84
fix tab. Need to make sure InRCut checks the RCutCoul on GPU, also e…
Oct 13, 2021
ee5378e
Modified kernels to return value. We already were passing rCutCoul box.
Oct 13, 2021
2ff6fed
make vertical the method sigs and moving to consistent and clear var …
Oct 13, 2021
15f264a
En builds
Oct 13, 2021
febc42e
EN builds
Oct 13, 2021
648ddf9
Pass parameters to CalcCoulForce
Oct 14, 2021
ef5bbe2
PArticle
Oct 14, 2021
73550e9
Shift
Oct 14, 2021
34f1d5a
Middle methods
Oct 14, 2021
e1623b5
All potentials now support wolf for force and energy on the GPU
Oct 14, 2021
7a51e81
Removed openMP from Wolf CPU
Oct 14, 2021
16b63ab
Add alot of err chk
Oct 15, 2021
668a846
found the bug
Oct 15, 2021
bdd1f97
fix the potentials in GPU
Oct 18, 2021
b4f97d8
Fixed WolfFactor2
Oct 21, 2021
0b27ecf
Self term was 2 times to large.
Oct 21, 2021
1142dd4
Add Cassandra's QQfact. Left old one in comment
Oct 22, 2021
3c33bef
increased precision.
Oct 23, 2021
099e07d
Changed variable we add DSF term in Correction methods. Initial ener…
Oct 26, 2021
45f13dc
If wolf is true and electrostatic false, set electrostatic true
Oct 28, 2021
0bafeec
first push
Sep 22, 2021
e17b89f
merged wolf and targetswap changes to config setup
Sep 22, 2021
ec4c4b5
fix SwapCorrection continue term by adding an abs, also differentiate…
Sep 22, 2021
fc9dda9
add metamake and config setup
Sep 22, 2021
2ea2153
pass wolf boolean to GPU kernels
Oct 12, 2021
f578cfd
Push
Oct 12, 2021
efe8317
Energy and FFParticle on GPU done.
Oct 13, 2021
72400ca
Pass to all the diff functions in En
Oct 13, 2021
a0ce586
fix tab. Need to make sure InRCut checks the RCutCoul on GPU, also e…
Oct 13, 2021
3c2702e
Modified kernels to return value. We already were passing rCutCoul box.
Oct 13, 2021
1b98256
make vertical the method sigs and moving to consistent and clear var …
Oct 13, 2021
1fb88ad
En builds
Oct 13, 2021
8a987f9
EN builds
Oct 13, 2021
32cf5b2
Pass parameters to CalcCoulForce
Oct 14, 2021
bd7723a
PArticle
Oct 14, 2021
2c0f580
Shift
Oct 14, 2021
ad7842d
Middle methods
Oct 14, 2021
cab118e
All potentials now support wolf for force and energy on the GPU
Oct 14, 2021
57b9a6b
Removed openMP from Wolf CPU
Oct 14, 2021
0569135
Add alot of err chk
Oct 15, 2021
e5a0036
found the bug
Oct 15, 2021
b2ba569
fix the potentials in GPU
Oct 18, 2021
f49abd9
Fixed WolfFactor2
Oct 21, 2021
cba27fe
Self term was 2 times to large.
Oct 21, 2021
5d4e68f
Add Cassandra's QQfact. Left old one in comment
Oct 22, 2021
d34c84a
increased precision.
Oct 23, 2021
43c558a
Changed variable we add DSF term in Correction methods. Initial ener…
Oct 26, 2021
d089262
If wolf is true and electrostatic false, set electrostatic true
Oct 28, 2021
4ae71cb
Rebased wolfFromDev with development
Nov 2, 2021
f5d7c14
Merge error in metamake.sh
Nov 8, 2021
fab4725
More merge errors
Nov 8, 2021
f3990e3
added option to exclude 1-N
Nov 30, 2021
5d6e7ed
Added config files to calibrate wolf
Feb 2, 2022
ceca776
Add wolfoutput files
Feb 6, 2022
47478af
working on initting the wolfcal
Feb 6, 2022
0b879e6
Added WolfCalibrationFreq to output options in config file
Feb 6, 2022
1ec655e
Use ranges to set number of calib points
Feb 6, 2022
7eec7e5
Realizing I need to call the SystemTotal method in CalcEn with differ…
Feb 7, 2022
150dd5e
started modifying FFParticle methods.
Feb 13, 2022
d424e6d
Revert "started modifying FFParticle methods."
GregorySchwing Feb 13, 2022
98eab25
Revert "Revert "started modifying FFParticle methods.""
GregorySchwing Feb 13, 2022
f82f205
Revert "Revert "Revert "started modifying FFParticle methods."""
GregorySchwing Feb 13, 2022
e75aa14
using default indexes to determine whether I am calibrating or runnin…
GregorySchwing Feb 13, 2022
4214490
pass a wolf calibration flag.
GregorySchwing Feb 13, 2022
d786685
Revert "pass a wolf calibration flag."
GregorySchwing Feb 14, 2022
dda28b7
set numberofRcuts to 1
GregorySchwing Feb 14, 2022
2039e22
renamed var and added var to CalcCoulVir
GregorySchwing Feb 14, 2022
9c6888f
decided on a pattern
GregorySchwing Feb 14, 2022
0b5e59d
moved the processing of the config file to Forcefield Cobj initializa…
GregorySchwing Feb 14, 2022
ec67e9e
pass stat val wolfcal object to ff
GregorySchwing Feb 14, 2022
bacbee3
updated most of ff classes to use double pointers and default arguments
GregorySchwing Feb 14, 2022
19cad05
need to update wolfAlpha now
GregorySchwing Feb 14, 2022
b6d4914
need to update wolfFactor terms. not sure how I will do this yet
GregorySchwing Feb 14, 2022
d0b4571
use correct data structures for all but Wolf class
GregorySchwing Feb 16, 2022
bb11a0f
temporary made wolf class only use config file alpha and rcut
GregorySchwing Feb 16, 2022
7578644
dynamically allocate double and triple pointers. in Forcefield
GregorySchwing Feb 16, 2022
7b0244a
alloc and dealloc mem methods written
GregorySchwing Feb 16, 2022
19aae34
Think I'm initting the calibration vals correctly
GregorySchwing Feb 16, 2022
32aa504
overwrite last val if explicitlyAddEnd true
GregorySchwing Feb 17, 2022
77ea1eb
can test wolf cal output header
GregorySchwing Feb 17, 2022
8a45022
actually call writeheader
GregorySchwing Feb 17, 2022
13802a8
wolf cal works
Feb 17, 2022
a6ee4ad
should calculate energies for all alphas and rcuts
Feb 17, 2022
3954196
WRite par files for grace. I likely will write separate files separa…
Feb 17, 2022
504828b
switch from wolf to ewald for ref pairs. Also init the ewald refewal…
Feb 17, 2022
ca7dfa9
actually use the indices I pass...
Feb 17, 2022
e5b59a9
dont turn on ewald yet..
Feb 17, 2022
6289eaf
add a comment
Feb 18, 2022
3f264df
updated wolf class for calibrating
Feb 19, 2022
9120644
self and intra. now need virial
Feb 19, 2022
8758185
separate Energy term intra into vdw and real
Feb 20, 2022
e791787
dont pass alpha to calc1-4Coul
Feb 20, 2022
3a95767
builds. Going to do this the clean way. I just need a way to pass i…
Feb 20, 2022
81b5a22
intra done
Feb 20, 2022
b9bb580
Wrote one method to do the full energy calc. Still need to test, and…
Feb 21, 2022
d7700ed
new approach produces reasonable xmgrace energy plots
Feb 21, 2022
92478bf
seems to be working
Feb 21, 2022
eb87b09
done
Feb 21, 2022
2196e21
removed the duplicate columns in wolf cal file.
Feb 27, 2022
fd11c8b
machinery to swap coul kinds and wolf kinds in cal
Feb 27, 2022
7922553
wrote methods to get and set coul and wolf kind. need to expand the …
Feb 27, 2022
4cc2fe4
wrapped up method cal. Might be biased to use one method to evolve s…
Feb 27, 2022
235748d
fix bug in for loop for coul kinds
Feb 27, 2022
7daaaeb
dont calc cal energy for 0,0 rcut,alpha
Feb 27, 2022
733acd5
fixed wolfCalOut
Mar 1, 2022
e0147ff
fix par file
Mar 1, 2022
2aec7ed
finalize
Mar 1, 2022
4bf3572
renamed cassandra to vlugt with intra cutoff
Apr 5, 2022
43fd2e7
use coulkind...
Apr 12, 2022
4dba335
fix initialization of wolf and ewald in calibration
Apr 12, 2022
6ce71e8
had to make get and set wolf and coul kind methods virtual
Apr 12, 2022
490867a
print memory in console
Apr 15, 2022
4b86d9a
wolfCal was defaulting to enabled
Apr 15, 2022
4e12416
Activate wolf cal enable in datastructure
Apr 15, 2022
41ec9f1
hopefully works on intel
Apr 18, 2022
61b576f
realizing I have a bug in intra nonbonded wolf
Apr 18, 2022
e3623fb
make sure rcutSeq uses the largest rcutcoul calib
Apr 18, 2022
d4eabce
think I have a working Vlugt
Apr 18, 2022
6e8c60e
removed dsf potential from intra correction
Apr 18, 2022
a9d6b71
remove more intra dsf stuff that shouldnt be there
Apr 18, 2022
6cd6b3f
fix self
Apr 18, 2022
272f4ca
use unified intra iteration
Apr 18, 2022
68e72c6
Revert "use unified intra iteration"
Apr 18, 2022
22e5bc4
change behavior of inter. fix self
Apr 18, 2022
8aa7259
last thing to check is wolf kind when calculating reference.
Apr 18, 2022
1e0b596
fix switch between ewald and wolf
Apr 18, 2022
d9ab20d
removed unused vars in CalcEn, ewald and wolf. only electrostatic bo…
Apr 18, 2022
df50cea
add some couts
Apr 19, 2022
f78e98d
use std::abs
Apr 19, 2022
fcd2f91
cal done
Apr 19, 2022
b3e107e
cassandra is spot on for correction and self. Cassandra uses dsf pot…
Apr 19, 2022
9e1f5cc
bug fix
Apr 20, 2022
948c8c3
GPU version builds. doesnt support calibrate, and still need to test
Apr 26, 2022
a2883a8
Revert "GPU version builds. doesnt support calibrate, and still need…
Apr 27, 2022
365d1e4
started toward flat
Apr 27, 2022
4d4aac6
all ff cutoffs
Apr 27, 2022
6670774
fix alphas.
Apr 27, 2022
4ddb354
rCutCoul.
Apr 27, 2022
6a8d97c
should set the startIndex of each wolf ffactor array
Apr 27, 2022
8c12cc7
should set the startIndex of each wolf ffactor array
Apr 27, 2022
49083e9
closer
Apr 27, 2022
31682d6
might have to sell
Apr 27, 2022
aa5651f
directly pass wolfalpha nad rcc
Apr 27, 2022
8a04c21
directly pass method sig
Apr 27, 2022
45136e0
keep going
Apr 27, 2022
9f10f66
CalcCoul and CalCoulVir done
Apr 27, 2022
725a924
CalcCoul and CalCoulVir done
Apr 27, 2022
32014e8
CalcCoul and CalCoulVir done
Apr 27, 2022
2a889bb
CalcCoul and CalCoulVir done
Apr 27, 2022
bad1af2
CalcCoul and CalCoulVir done
Apr 27, 2022
4eafa5f
CalcCoul and CalCoulVir done
Apr 27, 2022
f69795d
CalcCoul and CalCoulVir done
Apr 27, 2022
621fc22
CalcCoul and CalCoulVir done
Apr 27, 2022
3ce4321
done
Apr 27, 2022
0f4344f
done
Apr 27, 2022
98baf3d
done
Apr 27, 2022
32ad3bd
Standard wolf should work
Apr 27, 2022
d857ccf
revert GPU and move cal into new file
Apr 28, 2022
e7a8c5a
:w:
Apr 28, 2022
af3105d
BIITFO
Apr 28, 2022
4a01261
real wrong
Apr 28, 2022
8d079d8
need to debug
Apr 28, 2022
8e6a95f
index function seems to work and removed explicitly add logic
Apr 28, 2022
7e03c0f
working prototype
Apr 28, 2022
11289df
directly leaking memory since ff is type wolf
Apr 29, 2022
433c5eb
starting to work
Apr 29, 2022
2f37086
starting to work
Apr 29, 2022
7eb8e19
back to reference. still leaking 64 bytes
Apr 29, 2022
a0a2094
add nemetmc example
May 2, 2022
8eb5774
Revert "add nemetmc example"
May 2, 2022
b987b05
use new box inter method for vol t
May 2, 2022
83d54c7
fix intra
May 2, 2022
bb1ff3f
should be done cal
May 2, 2022
47abf09
remove endian test header
GregorySchwing May 16, 2022
e7d1313
remove lib endian
GregorySchwing May 16, 2022
90f18d7
add endian back
GregorySchwing May 16, 2022
9c2416b
add this till I get endian removed
GregorySchwing May 16, 2022
3851e32
crankshaft was calling ewald. I really should separate the ewald and…
May 16, 2022
ea5dbbc
add header for swapcorr wolf
May 16, 2022
84de2a9
add memory usage right after cpu alloc
May 16, 2022
228e365
move before cuda
May 16, 2022
1bfd6a8
fix cub
GregorySchwing Jun 1, 2022
ec0979c
moved wolf potential to its own line in config file
GregorySchwing Jul 15, 2022
9fb2277
wolf cal isnt correctly calculating the ewald ref
GregorySchwing Jul 18, 2022
45ab8e9
ref ewald matcxhes except for lrc and lj???
GregorySchwing Jul 18, 2022
06b4c70
should work now
GregorySchwing Jul 18, 2022
7b47927
use one SwapCorr method. There was some semantic difference where la…
GregorySchwing Aug 3, 2022
982c097
prevent double free
GregorySchwing Sep 5, 2022
6022e67
fix changeself wolf
GregorySchwing Sep 5, 2022
431aea1
compile error in molex1
GregorySchwing Sep 25, 2022
db72259
only require 1 set rcut alpha for gcmc
GregorySchwing Sep 26, 2022
448e7ea
also use NB for wolf cal methods
GregorySchwing Sep 26, 2022
ecccbdf
BOXES_WITH_U_NB in WolfCalOutput
GregorySchwing Sep 26, 2022
d757321
calibrate virial correctly and also, use gpu for boxinter wolf cal
GregorySchwing Sep 26, 2022
a596bd9
add to prago mp
GregorySchwing Sep 26, 2022
b688bbe
should be able to calibrate on the gpu
GregorySchwing Sep 26, 2022
afbf272
err in obj building
GregorySchwing Sep 26, 2022
7519aaf
gpu and cpu match for wolf cal.
GregorySchwing Sep 27, 2022
36c54f9
make sure ref sim uses the orig rcut coul. gpu and cpu diff by 0.00005%
GregorySchwing Sep 27, 2022
5cc6f3e
cal now uses ewald
GregorySchwing Sep 28, 2022
c7c4ef0
free wolf vars
GregorySchwing Sep 29, 2022
d73bc37
only use TotalElec for calibrating wolf
GregorySchwing Oct 11, 2022
e5da9d4
finished commenting out the override rcut for vlugt. should make cal…
GregorySchwing Oct 12, 2022
e601d2f
dont calibrate hybrd
GregorySchwing Oct 12, 2022
0071df1
dont calibrate hybrd
GregorySchwing Oct 12, 2022
bc5111a
Revert "finished commenting out the override rcut for vlugt. should …
GregorySchwing Oct 13, 2022
30a7c46
fix clock
GregorySchwing Oct 16, 2022
eea8780
fix gemc_nvt
GregorySchwing Nov 5, 2022
21de13a
fix swap self method
GregorySchwing Nov 5, 2022
b58bada
pass arch
GregorySchwing Nov 6, 2022
fdf08f1
fixed correction term. Vlugt/Cassandra was correct. Gross was incor…
GregorySchwing Nov 9, 2022
fb8d90b
pass entire rcc ptr :(
GregorySchwing Nov 10, 2022
b580bbc
same fix for force
GregorySchwing Nov 10, 2022
71d9485
fix get index method
GregorySchwing Nov 11, 2022
c762eb0
final bug fix for calibrating gemc
GregorySchwing Nov 11, 2022
8c1e73a
fix correction term
GregorySchwing Nov 11, 2022
ef1ce4a
Fix maxs bug locally
GregorySchwing Nov 11, 2022
3651ff8
builds
GregorySchwing Nov 11, 2022
14dced0
F
GregorySchwing Nov 11, 2022
e6329c0
fixed self temr
GregorySchwing Nov 14, 2022
8899940
ast fix..
GregorySchwing Nov 14, 2022
57c7cf2
fix correction term, but shouldnt explain error..
GregorySchwing Nov 14, 2022
54ffb21
fixed swap corr. still need to pass dest or source box though..
GregorySchwing Nov 18, 2022
01cdda4
fixed gemc wolf
GregorySchwing Nov 18, 2022
9588cac
dont add wf1 to hybrid without scaling
GregorySchwing Nov 26, 2022
ca014ab
changed hybrid wolf to be the fixed waibel2018 implementation
GregorySchwing Nov 26, 2022
8a3c161
cast to int in method sig
GregorySchwing Nov 26, 2022
89705df
update headers
GregorySchwing Nov 26, 2022
23dc582
iniitialize wolfCal boolean in ff
GregorySchwing Nov 27, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion CMake/FileLists.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,9 @@ set(sources
src/Simulation.cpp
src/StaticVals.cpp
src/System.cpp
src/Wolf.cpp
src/WolfCalibration.cpp
src/WolfCalibrationOutput.cpp
src/cbmc/DCCrankShaftAng.cpp
src/cbmc/DCCrankShaftDih.cpp
src/cbmc/DCCyclic.cpp
Expand Down Expand Up @@ -114,6 +117,7 @@ set(headers
src/HistOutput.h
src/InputAbstracts.h
src/InputFileReader.h
src/MemoryTracker.h
src/MersenneTwister.h
src/MoleculeKind.h
src/MoleculeLookup.h
Expand Down Expand Up @@ -146,6 +150,9 @@ set(headers
src/TransformMatrix.h
src/Velocity.h
src/Writer.h
src/Wolf.h
src/WolfCalibration.h
src/WolfCalibrationOutput.h
src/XYZArray.h
src/cbmc/DCComponent.h
src/cbmc/DCCrankShaftAng.h
Expand Down Expand Up @@ -173,7 +180,6 @@ set(headers
src/moves/IntraMoleculeExchange2.h
src/moves/IntraMoleculeExchange3.h
src/moves/IntraSwap.h
src/moves/IntraTargetedSwap.h
src/moves/MoleculeExchange1.h
src/moves/MoleculeExchange2.h
src/moves/MoleculeExchange3.h
Expand Down
4 changes: 4 additions & 0 deletions CMake/GOMCCUDASetup.cmake
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ if(ENSEMBLE_GPU_NVT)
set_target_properties(GPU_NVT PROPERTIES
CUDA_SEPARABLE_COMPILATION ON
OUTPUT_NAME ${GPU_NVT_name}
CUDA_ARCHITECTURES "35;60;70"
COMPILE_FLAGS "${GPU_NVT_flags}")
if (CMAKE_BUILD_TYPE STREQUAL "Debug")
message("-- Debug build type detected, GPU_NVT setting CUDA_RESOLVE_DEVICE_SYMBOLS ON")
Expand All @@ -62,6 +63,7 @@ if(ENSEMBLE_GPU_GEMC)
set_target_properties(GPU_GEMC PROPERTIES
CUDA_SEPARABLE_COMPILATION ON
OUTPUT_NAME ${GPU_GE_name}
CUDA_ARCHITECTURES "35;60;70"
COMPILE_FLAGS "${GPU_GE_flags}")
if (CMAKE_BUILD_TYPE STREQUAL "Debug")
message("-- Debug build type detected, GPU_GEMC setting CUDA_RESOLVE_DEVICE_SYMBOLS ON")
Expand All @@ -81,6 +83,7 @@ if(ENSEMBLE_GPU_GCMC)
set_target_properties(GPU_GCMC PROPERTIES
CUDA_SEPARABLE_COMPILATION ON
OUTPUT_NAME ${GPU_GC_name}
CUDA_ARCHITECTURES "35;60;70"
COMPILE_FLAGS "${GPU_GC_flags}")
if (CMAKE_BUILD_TYPE STREQUAL "Debug")
message("-- Debug build type detected, GPU_GCMC setting CUDA_RESOLVE_DEVICE_SYMBOLS ON")
Expand All @@ -100,6 +103,7 @@ if(ENSEMBLE_GPU_NPT)
set_target_properties(GPU_NPT PROPERTIES
CUDA_SEPARABLE_COMPILATION ON
OUTPUT_NAME ${GPU_NPT_name}
CUDA_ARCHITECTURES "35;60;70"
COMPILE_FLAGS "${GPU_NPT_flags}")
if (CMAKE_BUILD_TYPE STREQUAL "Debug")
message("-- Debug build type detected, GPU_NPT setting CUDA_RESOLVE_DEVICE_SYMBOLS ON")
Expand Down
1 change: 1 addition & 0 deletions lib/Endian.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@
*/

#include <stdlib.h>
#include <stdint.h>

#define bswap_64(x) \
((((x) & 0xff00000000000000ull) >> 56) \
Expand Down
33 changes: 24 additions & 9 deletions metamake.sh
Original file line number Diff line number Diff line change
Expand Up @@ -38,27 +38,28 @@ then
echo "==== GOMC needs CUB library to run..."
echo "==== Finding latest CUB library..."


# download the download html page
wget https://nvlabs.github.io/cub/download_cub.html > /dev/null 2>&1
#wget https://nvlabs.github.io/cub/download_cub.html > /dev/null 2>&1

# find the lines that have the link
grep "https://github.com/NVlabs/" download_cub.html > link_lines
#grep "https://github.com/NVlabs/" download_cub.html > link_lines

# the last line is the easiest to find the link
awk '/./{line=$0} END{print line}' link_lines > last_line
#awk '/./{line=$0} END{print line}' link_lines > last_line

# the substring between two quotes is the link!!!!
LINK="$(awk -F'"' '{ print $2 }' last_line)"
echo "==== Link found at ${LINK}"
#LINK="$(awk -F'"' '{ print $2 }' last_line)"
#echo "==== Link found at ${LINK}"

# remove any temporary files
rm link_lines
rm download_cub.html
rm last_line
#rm link_lines
#rm download_cub.html
#rm last_line

# download the zip file
echo "==== Downloading the CUB library... (Shouldn't take too long)"
wget "${LINK}" > /dev/null 2>&1
wget https://github.com/NVIDIA/cub/archive/refs/tags/1.8.0.zip > /dev/null 2>&1

#unzip
echo "==== Extracting the CUB library..."
Expand Down Expand Up @@ -151,12 +152,26 @@ else
ENSEMBLES+="GOMC_NPT_MPI_Test "
ENSEMBLES+="GOMC_GCMC_MPI_Test "
ENSEMBLES+="GOMC_GEMC_MPI_Test "
if(( use_cuda ))
then
ENSEMBLES+="GOMC_GPU_NVT_MPI_Test "
ENSEMBLES+="GOMC_GPU_NPT_MPI_Test "
ENSEMBLES+="GOMC_GPU_GCMC_MPI_Test "
ENSEMBLES+="GOMC_GPU_GEMC_MPI_Test "
fi
CMAKEARGS+="-DGOMC_GTEST_MPI=on "
else
ENSEMBLES+="GOMC_NVT_Test "
ENSEMBLES+="GOMC_NPT_Test "
ENSEMBLES+="GOMC_GCMC_Test "
ENSEMBLES+="GOMC_GEMC_Test "
if(( use_cuda ))
then
ENSEMBLES+="GOMC_GPU_NVT_Test "
ENSEMBLES+="GOMC_GPU_NPT_Test "
ENSEMBLES+="GOMC_GPU_GCMC_Test "
ENSEMBLES+="GOMC_GPU_GEMC_Test "
fi
CMAKEARGS+="-DGOMC_GTEST=on "
fi
export CC="$(which gcc 2> /dev/null)"
Expand Down
2 changes: 1 addition & 1 deletion src/BlockOutput.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -217,7 +217,7 @@ void BlockAverages::InitWatchSingle(config_setup::TrackedVars const& tracked)
blocks[out::PRESSURE_IDX].SetRef(&var->pressure[b], b);
blocks[out::MOL_NUM_IDX].SetRef(&var->numByBox[b], b);
blocks[out::DENSITY_IDX].SetRef(&var->densityTot[b], b);
blocks[out::COMPRESSIBILITY_IDX].SetRef(&var->compressability[b], b);
blocks[out::COMPRESSIBILITY_IDX].SetRef(&var->compressibility[b], b);
blocks[out::ENTHALPY_IDX].SetRef(&var->enthalpy[b], b);
blocks[out::SURF_TENSION_IDX].SetRef(&var->surfaceTens[b], b);
#if ENSEMBLE == GEMC
Expand Down
12 changes: 12 additions & 0 deletions src/BoxDimensions.h
Original file line number Diff line number Diff line change
Expand Up @@ -130,6 +130,10 @@ class BoxDimensions
bool InRcut(double & distSq, XYZArray const& arr1,
const uint i, XYZArray const& arr2, const uint j,
const uint b) const;

bool InRcut(double & distSq, double cutoff, XYZ & dist,
XYZArray const& arr, const uint i,
const uint j, const uint b) const;
/*
bool InRcut(double distSq) const
{
Expand Down Expand Up @@ -247,6 +251,14 @@ inline bool BoxDimensions::InRcut(double & distSq, XYZ & dist,
return (rCutSq[b] > distSq);
}

inline bool BoxDimensions::InRcut(double & distSq, double cutoff, XYZ & dist,
XYZArray const& arr, const uint i,
const uint j, const uint b) const
{
dist = MinImage(arr.Difference(i, j), b);
distSq = dist.x * dist.x + dist.y * dist.y + dist.z * dist.z;
return (cutoff > distSq);
}

inline bool BoxDimensions::InRcut(double & distSq, XYZ & dist,
XYZArray const& arr1, const uint i,
Expand Down
5 changes: 4 additions & 1 deletion src/CPUSide.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,8 @@ CPUSide::CPUSide(System & sys, StaticVals & statV, Setup & set) :
psf(statV.mol, sys, set),
xstBinary(sys, statV),
console(varRef), block(varRef),
hist(varRef), checkpoint(sys, statV)
hist(varRef), checkpoint(sys, statV),
wolfCalibration(sys, statV)
#if ENSEMBLE == GCMC
, sample_N_E(varRef)
#endif
Expand Down Expand Up @@ -45,6 +46,8 @@ void CPUSide::Init( PDBSetup const& pdbSet,
outObj.push_back(&block);
if (out.restart.settings.enable)
outObj.push_back(&checkpoint);
if (out.wolfCalibration.settings.enable)
outObj.push_back(&wolfCalibration);

#if ENSEMBLE == GCMC
outObj.push_back(&hist);
Expand Down
2 changes: 2 additions & 0 deletions src/CPUSide.h
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ along with this program, also can be found at <http://www.gnu.org/licenses/>.
#include "CheckpointOutput.h"
#include "EnPartCntSampleOutput.h"
#include "FreeEnergyOutput.h"
#include "WolfCalibrationOutput.h"
#include "PSFOutput.h"

#include <vector>
Expand Down Expand Up @@ -50,6 +51,7 @@ struct CPUSide {
BlockAverages block;
Histogram hist;
CheckpointOutput checkpoint;
WolfCalibrationOutput wolfCalibration;
#if ENSEMBLE == GCMC
EnPartCntSample sample_N_E;
#endif
Expand Down
Loading