233 ensure relevant notebooks have selection example #242
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-example fix conflict
|
My bad. forgot to update a selection test. Will do now |
|
Should be good to go now @astrofle |
|
There's one error in the subbeamnod notebook: ValueError Traceback (most recent call last)
Cell In[5], line 1
----> 1 sb3=sdfits.subbeamnod(method='scan')
File [/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/fits/gbtfitsload.py:1189](http://fourier.gb.nrao.edu:9030/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/fits/gbtfitsload.py#line=1188), in GBTFITSLoad.subbeamnod(self, method, sig, cal, calibrate, timeaverage, polaverage, weights, bintable, **kwargs)
1186 reftp.append(tpoff[0])
1187 # in order to reproduce gbtidl tsys, we need to do a normal
1188 # total power scan
-> 1189 ftp = self.gettp(
1190 scan=scan,
1191 sig=None,
1192 cal=None,
1193 bintable=bintable,
1194 fdnum=fn,
1195 plnum=plnum,
1196 ifnum=k,
1197 weights=weights,
1198 calibrate=calibrate,
1199 ) # .timeaverage(weights=w)
1200 fulltp.append(ftp[0])
1201 sb = SubBeamNodScan(sigtp, reftp, fulltp, method=method, calibrate=calibrate, weights=weights)
File [/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/fits/gbtfitsload.py:925](http://fourier.gb.nrao.edu:9030/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/fits/gbtfitsload.py#line=924), in GBTFITSLoad.gettp(self, sig, cal, calibrate, timeaverage, polaverage, weights, bintable, **kwargs)
923 kwargs[k] = v
924 # now downselect with any additional kwargs
--> 925 ps_selection._select_from_mixed_kwargs(**kwargs)
926 _sf = ps_selection.final
927 ifnum = uniq(_sf["IFNUM"])
File [/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/util/selection.py:835](http://fourier.gb.nrao.edu:9030/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/util/selection.py#line=834), in Selection._select_from_mixed_kwargs(self, **kwargs)
833 if debug:
834 print(f"selection {ukwargs}")
--> 835 self.select(**ukwargs, tag=tag)
File [/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/util/selection.py:544](http://fourier.gb.nrao.edu:9030/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/util/selection.py#line=543), in Selection.select(self, tag, **kwargs)
542 warnings.warn("Your selection rule resulted in no data being selected. Ignoring.")
543 return
--> 544 self._addrow(row, df, tag)
File [/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/util/selection.py:461](http://fourier.gb.nrao.edu:9030/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/util/selection.py#line=460), in Selection._addrow(self, row, dataframe, tag)
442 def _addrow(self, row, dataframe, tag=None):
443 """
444 Common code to add a tagged row to the internal table after the selection has been created.
445 Should be called in select* methods.
(...)
459
460 """
--> 461 if self._check_for_duplicates(dataframe):
462 return
463 if tag is not None:
File [/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/util/selection.py:432](http://fourier.gb.nrao.edu:9030/home/sandboxes/psalas/Dysh/dysh-fs/src/dysh/util/selection.py#line=431), in Selection._check_for_duplicates(self, df)
429 for _id, s in self._selection_rules.items():
430 if s.equals(df):
431 # print(s, df)
--> 432 tag = self._table.loc[_id]["TAG"]
433 # raise Exception(
434 warnings.warn(
435 f"A rule that results in an identical selection has already been added: ID: {_id}, TAG:{tag}."
436 " Ignoring."
437 )
File [/home/sandboxes/psalas/Dysh/dysh-fs/dysh-py3.11/lib/python3.11/site-packages/astropy/table/index.py:876](http://fourier.gb.nrao.edu:9030/home/sandboxes/psalas/Dysh/dysh-fs/dysh-py3.11/lib/python3.11/site-packages/astropy/table/index.py#line=875), in TableLoc.__getitem__(self, item)
863 def __getitem__(self, item):
864 """
865 Retrieve Table rows by value slice.
866
(...)
874 second element must be as above.
875 """
--> 876 rows = self._get_rows(item)
878 if len(rows) == 0: # no matches found
879 raise KeyError(f"No matches found for key {item}")
File [/home/sandboxes/psalas/Dysh/dysh-fs/dysh-py3.11/lib/python3.11/site-packages/astropy/table/index.py:834](http://fourier.gb.nrao.edu:9030/home/sandboxes/psalas/Dysh/dysh-fs/dysh-py3.11/lib/python3.11/site-packages/astropy/table/index.py#line=833), in TableLoc._get_rows(self, item)
830 """
831 Retrieve Table rows indexes by value slice.
832 """
833 if len(self.indices) == 0:
--> 834 raise ValueError("Can only use TableLoc for a table with indices")
836 if isinstance(item, tuple):
837 key, item = item
ValueError: Can only use TableLoc for a table with indices |
The error shows up when using |
|
astropy pinned to <6.1. FS notebook changed to use wget |
astrofle
approved these changes
May 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR puts selection-based calibration examples in existing notebooks.
Also adds compound exclusion region baseline examplle to frequency switch notebook.
Also fixes a bug in getfs when using selection.