Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs and add test files #167

Merged
merged 10 commits into from
Dec 14, 2023
Merged

Update docs and add test files #167

merged 10 commits into from
Dec 14, 2023

Conversation

astrofle
Copy link
Collaborator

Updated docs and added test files for Doppler corrections.

The documentation updates are in response to the beta testing feedback.
See Issue #148

@astrofle astrofle requested a review from mpound December 14, 2023 15:34
@mpound
Copy link
Collaborator

mpound commented Dec 14, 2023

For each scan in the summary() row, dysh takes the mean of numeric columns
VELOCITY, RESTFREQ, DOPFREQ, AZIMUTH, ELEVATIO
so these may differ from GBTIDL if it is reporting only the first integration values. (If verbose=True you get all the integrations)

Please update the note.

Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See conversation about other numeric columns being averaged. Docs should be tweaked.

@astrofle
Copy link
Collaborator Author

Tweaked the note to include the missing columns.

@astrofle astrofle requested a review from mpound December 14, 2023 16:12
@astrofle astrofle linked an issue Dec 14, 2023 that may be closed by this pull request
@astrofle astrofle merged commit 2adcab2 into main Dec 14, 2023
14 checks passed
@astrofle astrofle deleted the update-docs branch December 14, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azimuth values in GBTFITSLoad.summary()
2 participants