Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sphinx warnings #157

Merged
merged 3 commits into from
Dec 8, 2023
Merged

Fix Sphinx warnings #157

merged 3 commits into from
Dec 8, 2023

Conversation

vcatlett
Copy link
Contributor

@vcatlett vcatlett commented Dec 6, 2023

Small changes to fix sphinx-autobuild warnings. Will comment details on the individual changes.

.gitignore Outdated
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a line to .gitignore so I don't accidentally publish by docs environment

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added the contents of install_developer.rst here for two reasons. First, it consolidates our scattered installation a bit. Secondly, it cleared the following warnings:

/home/sandboxes/vcatlett/repos/github/dysh/docs/source/for_developers/install_developer.rst:12: WARNING: duplicate label dysh1, other instance in /home/sandboxes/vcatlett/repos/github/dysh/docs/source/for_developers/install.rst
/home/sandboxes/vcatlett/repos/github/dysh/docs/source/for_developers/install_developer.rst:81: WARNING: duplicate label dysh2, other instance in /home/sandboxes/vcatlett/repos/github/dysh/docs/source/for_developers/install.rst
/home/sandboxes/vcatlett/repos/github/dysh/docs/source/for_developers/install_developer.rst:122: WARNING: duplicate label dysh3, other instance in /home/sandboxes/vcatlett/repos/github/dysh/docs/source/for_developers/install.rst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comment on the changes to docs/source/for_developers/install.rst

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a space to resolve this error:

/home/sandboxes/vcatlett/repos/github/dysh/docs/source/getting_started/tutorials/GBT/index.rst:5: ERROR: Error in "toctree" directive:
invalid option block.

.. toctree::
:maxdepth: 2
tutorial-positionswitch

docs/source/index.rst Outdated Show resolved Hide resolved
src/dysh/spectra/core.py Outdated Show resolved Hide resolved
Comment on lines +1 to +3
"""
Plot a spectrum using matplotlib
"""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, I just added line breaks to the file's docstring because I think it looks better

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tchamberlin & @vcatlett has this been resolved?

.gitignore Outdated Show resolved Hide resolved
Co-authored-by: Thomas Chamberlin <[email protected]>
@tchamberlin tchamberlin merged commit 9a7e9e4 into main Dec 8, 2023
13 checks passed
@vcatlett vcatlett deleted the cat-docs branch December 11, 2023 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants