Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various minor tweaks to clean up the repo #150

Merged
merged 7 commits into from
Dec 5, 2023
Merged

Various minor tweaks to clean up the repo #150

merged 7 commits into from
Dec 5, 2023

Conversation

tchamberlin
Copy link
Member

As per #140, various unused files have been removed (GUI code, attic, etc.). Note that wget has not been removed in this PR; this is functional change that I'll address separately

As per #139, the dependencies in pyproject.toml have been updated/reorganized

@tchamberlin
Fix dependencies
15272c8
@tchamberlin
Remove GUI; will move to separate repo
ffdb5e0
@tchamberlin
Remove autoconf/make files
6748f9f
@tchamberlin
Fixed usage of __all__
b7d2889 
I _think_ __all__ should now be functioning as intended. But I'm not sure that the way it's intended to work makes sense -- need to discuss
@tchamberlin
Remove _dysh_init.py
bcdb453
@tchamberlin
Reorganize shell code
b8512b2
@tchamberlin tchamberlin mentioned this pull request Dec 5, 2023
Closed
@tchamberlin tchamberlin requested a review from mpound December 5, 2023 16:22
This was referenced Dec 5, 2023
Merged
Closed
mpound
mpound approved these changes Dec 5, 2023
View reviewed changes
Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is myst-parser no longer needed?

@tchamberlin
Copy link
Member Author

It appears not -- we don't have any documentation source in .md files at least. I'd be fine dropping it

@tchamberlin
Remove myst-parser dep
d58391b 
Sort deps alphabetically. Change dysh[all] syntax
@tchamberlin tchamberlin merged commit 5793e0b into main Dec 5, 2023
13 checks passed
@tchamberlin
Copy link
Member Author

I have made some final tweaks to the dependencies:

  • sorted them alphabetically
  • changed all = ["dysh[dev]", "dysh[nb]"] to all = ["dysh[dev,nb]"]

@tchamberlin tchamberlin deleted the cleanup branch December 7, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpound mpound mpound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchamberlin @mpound