Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs for beta #131

Merged
merged 6 commits into from
Nov 25, 2023
Merged

Update docs for beta #131

merged 6 commits into from
Nov 25, 2023

Conversation

astrofle
Copy link
Collaborator

This PR updates the examples to work with ScanBlocks. It is mainly changing from ta.plot() to ta[0].plot().
It also changes the GBTSDFITSLoader.summary to print when using show_index=False.

Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are changing gbtfitsload.py to print() the index if show_index=False, then we should default to show_index=True so that the user does not have to type it to get pretty output in a notebook. i.e., summary() with no arguments should to the prettiest thing.

@astrofle
Copy link
Collaborator Author

Agree. Changed now.

@mpound mpound merged commit 16a3941 into release-0.2.0 Nov 25, 2023
13 checks passed
@astrofle astrofle deleted the update_docs_for_beta branch November 27, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants