Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add unit tests for dysh shell #125

Merged
merged 4 commits into from
Nov 21, 2023
Merged

Add unit tests for dysh shell #125

merged 4 commits into from
Nov 21, 2023

Conversation

tchamberlin
Copy link
Member

Add some very basic unit tests to prove that dysh shell at least works without errors

@tchamberlin tchamberlin mentioned this pull request Nov 21, 2023
Closed
@tchamberlin tchamberlin marked this pull request as ready for review November 21, 2023 18:16
@tchamberlin tchamberlin requested a review from mpound November 21, 2023 18:16
@tchamberlin tchamberlin self-assigned this Nov 21, 2023
mpound
mpound approved these changes Nov 21, 2023
View reviewed changes
Copy link
Collaborator

@mpound mpound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

today I learn about monkeypatching!

@mpound
Copy link
Collaborator

mpound commented Nov 21, 2023

Did you want me to merge this or not?

@tchamberlin
Copy link
Member Author

Yes, I think this is ready to merge

@astrofle astrofle merged commit 44585ed into release-0.2.0 Nov 21, 2023
13 checks passed
@tchamberlin tchamberlin deleted the ipython_dep_v2 branch December 7, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpound mpound mpound approved these changes

Assignees

@tchamberlin tchamberlin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tchamberlin @mpound @astrofle