Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make ipython a core dependency #123

Merged
merged 1 commit into from
Nov 21, 2023
Merged

Make ipython a core dependency #123

merged 1 commit into from
Nov 21, 2023

Conversation

tchamberlin
Copy link
Member

$ dysh (dysh.shell) requires ipython, so it needs to be migrated from an optional to a "core" dependency

@tchamberlin tchamberlin requested a review from mpound November 21, 2023 17:16
@tchamberlin tchamberlin marked this pull request as draft November 21, 2023 17:17
@tchamberlin
Copy link
Member Author

I can add a unit test for this

@mpound mpound marked this pull request as ready for review November 21, 2023 17:20
@mpound mpound merged commit 9453334 into release-0.2.0 Nov 21, 2023
13 checks passed
@tchamberlin
Copy link
Member Author

Please don't accept draft PRs; once they are done they'll be marked as ready

@tchamberlin tchamberlin deleted the ipython_dep branch December 7, 2023 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpound mpound mpound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tchamberlin @mpound