Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider assigned perspective when merging navigation dropdowns. #21295

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

linuspahl
Copy link
Contributor

Description

Motivation and Context

It is possible to merge navigation dropdowns, by using the same dropdown title. This way navigation dropdowns from core can be extended via plugins.

With this PR we are also considering the perspective when merging the dropdowns. They only get merged, when their assigned perspective matches.

/nocl

@linuspahl linuspahl marked this pull request as ready for review January 8, 2025 18:29
@linuspahl linuspahl requested a review from a team January 8, 2025 18:29
@linuspahl linuspahl merged commit 73a5fc9 into master Jan 9, 2025
7 checks passed
@linuspahl linuspahl deleted the improve-merged-nav-dropdowns branch January 9, 2025 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants