Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide ReplaySearchContext for replayed search augmentations. #21291

Merged
merged 13 commits into from
Jan 9, 2025

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jan 8, 2025

Description

Motivation and Context

This PR is doing two things to improve embedding searches:

  • Provide a ReplaySearch component to simplify/consolidate the common pattern of embedding a replayed search for events/event definitions
  • Provide and use a ReplaySearchContext instead of parsing the URL to make replayed search augmentations (e.g. showing event metadata on top) more modular

/nocl Internal Refactoring.
/prd Graylog2/graylog-plugin-enterprise#9482

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers force-pushed the refactor/replay-search-augmentation branch from a99cb6d to 3e92e09 Compare January 9, 2025 07:24
@maxiadlovskii maxiadlovskii self-requested a review January 9, 2025 11:56
@dennisoelkers dennisoelkers merged commit ad934d3 into master Jan 9, 2025
7 checks passed
@dennisoelkers dennisoelkers deleted the refactor/replay-search-augmentation branch January 9, 2025 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants