-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move truststore creator to server package for cloud builds #21279
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Haven't run the cloud build locally (Bernd will), but the code changes lgtm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Cloud build now fails with the following error:
[ERROR] /home/bernd/graylog/cloud-builds/modules/graylog2-server/full-backend-tests/src/test/java/org/graylog/datanode/ClientCertResourceIT.java:[31,36] error: cannot find symbol
symbol: class TruststoreCreator
location: package org.graylog.security.certutil
[ERROR] /home/bernd/graylog/cloud-builds/modules/graylog2-server/full-backend-tests/src/test/java/org/graylog/datanode/ClientCertResourceIT.java:[134,15] error: cannot find symbol
symbol: variable TruststoreCreator
location: class ClientCertResourceIT
[INFO] 2 errors
The |
I think we shouldn't create packages other than |
We have a "skip.datanode" build option that fails when using Data Node related packages outside of the data-node Maven module. This adds the restrict-imports-enforcer-rule enforcer plugin to get access to the "RestrictImports" rules. Refs #21279
Sorry for the confusion, moving class between packages in idea did something that I haven't expected and created new package in the same project, instead of moving to an existing package in the server project. Fixed now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The Cloud build works again. Thanks!
/nocl internal refactoring
Types of changes
Checklist: