Fix to load indices status in batches so that the URL used to call OpenSearch does not exceed maximum length (6.0)
#21269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…enSearch does not exceed maximum length (#21208) * fix to load status in batches so that the url does not get too long * partitioning over the length of the names, added changelog * fix calculation error * fix calculation error * switching approach * switching approach * fixing test * refactorings * fix error during refactorings * adding more block types * Fixing max
dennisoelkers
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This is a backport of #21208 to
6.0.Description
Prior to this PR, a call to
getIndicesBlocksStatus()would exceed to URL maximum of 4096 bytes if the number of indices would be large.Motivation and Context
How Has This Been Tested?
Tested manually by setting index.blocks on indices manually in OpenSearch and by reducing the threshold to a small amount that leads to reading all indices instead of only the list.
Screenshots (if appropriate):
Types of changes
Checklist: