Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding "Replay Search" bulk action for alerts/events. #21262

Merged
merged 26 commits into from
Jan 8, 2025

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Jan 3, 2025

Description

Motivation and Context

This PR is adding a bulk action that allows replaying searches for multiple alerts/events. This is targeted at analysts wanting to investigate multiple events closely, filtering out non-relevant events and performing actions on the ones remaining. To support this, this feature is building a stack of events, showing the on the left side of the screen, allowing the user to replay them one by one.

The user can now mark individual events as viewed, jumping to the next one which was not viewed yet. The user can also remove events which have turned out to be irrelevant. This allows the user to keep track of the progress and make sure that no event is missed. At the end, the user can perform further bulk actions on the events remaining in the stack.

How Has This Been Tested?

Screenshots (if appropriate):

bulk-replay-search-2

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers force-pushed the feat/bulk-replay-search branch from ff51066 to 84278fe Compare January 3, 2025 13:56
Copy link
Contributor

@maxiadlovskii maxiadlovskii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be nice to use the check mark only if an event is already investigated. I was a bit confused that none-investigated event has a darker color than investigated. We can use just a simple check box or some other icon for non investigated event

`);

const CompletedButton = styled(IconButton)<{ $done: boolean }>(({ theme, $done }) => css`
color: ${$done ? theme.colors.variant.success : theme.colors.global.textDefault};
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
color: ${$done ? theme.colors.variant.success : theme.colors.global.textDefault};
color: ${$done ? theme.colors.variant.success : theme.colors.gray[60]};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would make icon in the same color as trash icon

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@maxiadlovskii maxiadlovskii self-requested a review January 8, 2025 11:48
@dennisoelkers dennisoelkers merged commit 534c3eb into master Jan 8, 2025
6 of 7 checks passed
@dennisoelkers dennisoelkers deleted the feat/bulk-replay-search branch January 8, 2025 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants