Adding prettier for code formatting, disabling ESLint formatting rules. #18325
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennisoelkers
force-pushed
the
adding-prettier
branch
from
c430643 to
40f641e
Compare
dennisoelkers
force-pushed
the
adding-prettier
branch
from
40f641e to
67c0ab6
Compare
linuspahl
reviewed
Nov 7, 2024
| @@ -36,6 +36,9 @@ jobs: | |||
| continue-on-error: true | |||
| working-directory: graylog2-web-interface | |||
| run: yarn lint --fix -o /tmp/report.json -f json | |||
| - name: Runt prettier | |||
| @@ -24,7 +24,8 @@ | |||
| "lint:changes": "./dev/lintChanges.sh", | |||
| "test": "jest --maxWorkers=50%", | |||
| "test:integration": "jest --maxWorkers=50% --config jest.it.config.js", | |||
| "check-production-build": "node checkProductionBuild.js" | |||
| "check-production-build": "node checkProductionBuild.js", | |||
| "format": "prettier --write src" | |||
There was a problem hiding this comment.
In my opinion it also makes sense to apply the formatting for the test and maybe even the docs directory.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
This PR is adding
prettierfor code-formatting and disables ESLint rules that were previously used to ensure consistent formatting. The benefit ofprettieris its speed for code formatting, making it particularly useful when using the IDE integration.For the automatic code formatting in IntelliJ, the following setting should be used:
Existing settings for ESLint should be kept.
All code can be formatted from the command line as well, using:
This PR does not contain formatting, in order to keep it small and focussed. Actual code formatting for current code will be performed in a separate PR.
/nocl
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: