Revert pipeline processor invalid field access check due to regression #18322
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
lgtm. unfortunately, i can't think of a way to distinguish the two use cases either |
moesterheld
approved these changes
Mar 6, 2024
patrickmann
added a commit
that referenced
this pull request
Mar 7, 2024
#18322) * revert PR 16196 * CL --------- Co-authored-by: Matthias Oesterheld <[email protected]> (cherry picked from commit 3751137)
moesterheld
pushed a commit
that referenced
this pull request
Mar 15, 2024
#18322) (#18523) * revert PR 16196 * CL --------- Co-authored-by: Matthias Oesterheld <[email protected]> (cherry picked from commit 3751137)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #18017
#16029 was designed to flag illegal expressions like
<array>.[<index>]in a pipeline rule.However, we end up also blocking legal expressions, e.g. to access JSON fields of type array. JSON parsing allows using dot notation or square brackets interchangeably.
This PR reverts the change.
How Has This Been Tested?
Parser behaves as before:
rs.["a"]does not trigger a syntax error; error message visible in server log