Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagating error during field type change to frontend. #17000

Merged
merged 1 commit into from
Oct 19, 2023
Merged

Propagating error during field type change to frontend. #17000

merged 1 commit into from
Oct 19, 2023

Conversation

dennisoelkers
Copy link
Member

@dennisoelkers dennisoelkers commented Oct 19, 2023 •
edited
Loading

Description

Motivation and Context

This PR is making sure that any error during a field type change is propagated to the frontend.

Fixes #16978.

/nocl

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@dennisoelkers dennisoelkers requested a review from todvora October 19, 2023 07:57
@dennisoelkers dennisoelkers mentioned this pull request Oct 19, 2023
Merged
9 tasks
todvora
todvora approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@todvora todvora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy fix, thanks!

@todvora todvora merged commit 01a9f3b into master Oct 19, 2023
2 checks passed
@todvora todvora deleted the fix/issue-16978 branch October 19, 2023 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@todvora todvora todvora approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error in field type mapping doesn't propagate to frontend
2 participants
@dennisoelkers @todvora