Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump io.prometheus:simpleclient_bom from 0.11.0 to 0.16.0 #16743

Merged
merged 5 commits into from
Oct 30, 2023

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 28, 2023

Bumps io.prometheus:simpleclient_bom from 0.11.0 to 0.16.0.

Dependabot compatibility score

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file maven labels Sep 28, 2023
@bernd
Copy link
Member

bernd commented Sep 28, 2023

We need to check if the metric output is backwards compatible before we merge this PR.

@thll
Copy link
Contributor

thll commented Oct 27, 2023

@dependabot rebase

Bumps io.prometheus:simpleclient_bom from 0.11.0 to 0.16.0.

---
updated-dependencies:
- dependency-name: io.prometheus:simpleclient_bom
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot force-pushed the dependabot/maven/io.prometheus-simpleclient_bom-0.16.0 branch from dcf400d to bf2e855 Compare October 27, 2023 13:14
@thll
Copy link
Contributor

thll commented Oct 27, 2023

@bernd 0.16.0 seems to be the last release of the "prometheus simpleclient". Before moving to the current java client re-implementation of version1.0.0 I think we should wait until the dropwizard support has been ported over to 1.0.x. See prometheus/client_java#867.

I think it's still worthwhile to update to 0.16.0. I didn't see any difference in the output except for the this one. I think that's acceptable but because it's a breaking change, I added a reference to it to our changelog and upgrade nodes.

@thll thll requested a review from bernd October 27, 2023 14:15
@thll thll merged commit 34f8eb8 into master Oct 30, 2023
1 check passed
@thll thll deleted the dependabot/maven/io.prometheus-simpleclient_bom-0.16.0 branch October 30, 2023 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file maven
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants