Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make lookup table/periodicals startup less noisy. #14655

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dennisoelkers
Copy link
Member

Description

Motivation and Context

While debugging a startup error, I noticed that starting up lookup tables (plus data adapters and caches) has become pretty noisy for a standard distribution due to the high number of shipped content, making debugging a startup harder. In most cases, logging the startup of each lookup table, data adapter and cache is not necessary, so this PR is changing their log level to debug and prints a summary with the number of started lookup tables, as well as the total number and the number of failures instead.

How Has This Been Tested?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant