Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stream deletion propagated to Widgets #10971

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

janheise
Copy link
Contributor

@janheise janheise commented Jul 5, 2021

Description

The deletion event for a stream is read from the EventBus by a listener that checks all widgets for the stream reference and deletes the reference if necessary.

Motivation and Context

If a stream get's deleted, a widget might still reference that stream. This only becomes a problem (afaik) when the widget is part of a ContentPack that get's exported because during import, the stream can not be found and the import fails.

Because of possible performance issues, this is only a draft for now that might be picked up later after further discussion.

How Has This Been Tested?

manual tests

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [] New feature (non-breaking change which adds functionality)
  • Refactoring (non-breaking change)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • [] My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@janheise janheise force-pushed the ContentPackPropagateStreamDeletion branch from 05ddc10 to fa6470d Compare July 7, 2021 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant