Set unit settings to undefined on clear unit type (#21399)

Graylog2 · Jan 22, 2025 · deb945c · deb945c
1 parent cd3e38f
commit deb945c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/changelog/unreleased/issue-21398.toml b/changelog/unreleased/issue-21398.toml
@@ -0,0 +1,5 @@
+type = "f"
+message = "Fix an issue causing saving searches/dashboards after clearing the unit type to fail with error."
+
+pulls = ["21399"]
+issues = ["21398"]
diff --git a/graylog2-web-interface/src/views/components/aggregationwizard/units/FieldUnitPopover.tsx b/graylog2-web-interface/src/views/components/aggregationwizard/units/FieldUnitPopover.tsx
@@ -71,7 +71,10 @@ const FieldUnitPopover = ({ field, predefinedUnit }: { field: string, predefined
     .map(({ abbrev, name }: Unit) => ({ value: abbrev, label: capitalize(name) })), [currentUnitType]);
   const toggleShow = () => setShow((cur) => !cur);
   const onUnitTypeChange = useCallback((val: string) => {
-    setFieldValue(`units.${field}`, { unitType: val || undefined, abbrev: undefined });
+    const fieldUnitSettings = val
+      ? { unitType: val, abbrev: undefined }
+      : undefined;
+    setFieldValue(`units.${field}`, fieldUnitSettings);
   }, [field, setFieldValue]);
 
   const badgeLabel = useMemo(() => {