chore: upgrade more dependencies #9607
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
plumpy
changed the title
plumpy
force-pushed
the
upgrade_buildpacks
branch
from
72cbd96 to
26d5b03
Compare
plumpy
force-pushed
the
upgrade_buildpacks
branch
3 times, most recently
from
016644f to
d90498e
Compare
some YAML library changed how it indents lists
the godotenv parser is a little more liberal in what it parses, so we have to make our malformed test case a little extra malformed
plumpy
force-pushed
the
upgrade_buildpacks
branch
from
d90498e to
9955513
Compare
A change in kustomize meant that when you import its YAML libraries, you get a repackaged version of yaml.v3 instead of the real ones. This broke YAML parsing in a very confusing way. Specifically, UnmarshalClusterVolumes no longer implemented yaml.v3/Unmarshaller. Instead it implemented sigs.k8s.io/yaml/goyaml.v3/Unmarshaller. Which means the YAML parser just never bothered to call our custom Unmarshaller logic. None of this is particularly interesting, but it took me at least 8 hours to figure it out, so I wanted to write it down.
plumpy
force-pushed
the
upgrade_buildpacks
branch
from
9955513 to
a2dbcca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.