Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: pluralize sub-second fractions on human time #9098

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

0x2b3bfa0
Copy link

Description
This pull request fixes a silly bug where humanized time with a seconds component less than 1 doesn't get the plural for seconds as expected. Note, though, that this change is arguable as per some style guides; see https://english.stackexchange.com/q/365841/125512.

User facing changes

- 1 hour 3 minutes 0.5 second
+ 1 hour 3 minutes 0.5 seconds

@0x2b3bfa0 0x2b3bfa0 changed the title Add test case for plural usage on sub-second fractions fix: add test case for plural usage on sub-second fractions Sep 21, 2023
@0x2b3bfa0 0x2b3bfa0 changed the title fix: add test case for plural usage on sub-second fractions fix: pluralize sub-second fractions on human time Sep 21, 2023
@codecov
Copy link

codecov bot commented Sep 25, 2023

Codecov Report

Merging #9098 (00a78b3) into main (290280e) will decrease coverage by 7.05%.
Report is 1033 commits behind head on main.
The diff coverage is 48.90%.

@@            Coverage Diff             @@
##             main    #9098      +/-   ##
==========================================
- Coverage   70.48%   63.43%   -7.05%     
==========================================
  Files         515      628     +113     
  Lines       23150    32304    +9154     
==========================================
+ Hits        16317    20492    +4175     
- Misses       5776    10251    +4475     
- Partials     1057     1561     +504     
Files Changed Coverage Δ
cmd/skaffold/app/cmd/completion.go 13.04% <0.00%> (-1.25%) ⬇️
cmd/skaffold/app/cmd/config/list.go 65.21% <ø> (ø)
cmd/skaffold/app/cmd/config/set.go 88.72% <ø> (ø)
cmd/skaffold/app/cmd/config/util.go 54.28% <ø> (ø)
cmd/skaffold/app/cmd/credits.go 100.00% <ø> (ø)
cmd/skaffold/app/cmd/credits/export.go 0.00% <0.00%> (ø)
cmd/skaffold/app/cmd/deploy.go 40.90% <0.00%> (-12.94%) ⬇️
cmd/skaffold/app/cmd/generate_pipeline.go 60.00% <ø> (ø)
cmd/skaffold/app/cmd/inspect_modules.go 65.00% <0.00%> (ø)
cmd/skaffold/app/cmd/inspect_profiles.go 66.66% <0.00%> (ø)
... and 41 more

... and 432 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant