Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove deletion_protection variable argument #275

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

regisferlima
Copy link

@regisferlima regisferlima commented Dec 10, 2024

We are facing an issue with the new version of 0.15.3

Something is out of sync with the API and the official documentation of Terraform and the module.

Seems that **deletion_protection** is not expected on the resource "google_cloud_run_v2_service"

image

@regisferlima regisferlima requested review from prabhu34, anamer, gtsorbo, q2w and a team as code owners December 10, 2024 14:22
Copy link

google-cla bot commented Dec 10, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@regisferlima regisferlima changed the title Remove deletion_protection variable argument Fix: Remove deletion_protection variable argument Dec 10, 2024
@regisferlima
Copy link
Author

/gcbrun

@apeabody
Copy link
Contributor

Hi @regisferlima - It looks like deletion_protection was added in TPGv6.0, can you try upgrading your provider? e.g terraform init --upgrade.

Hi @daniel-cit - As a follow-up to #257, could we add a >= 6 to the Terraform version constraint.

@regisferlima
Copy link
Author

regisferlima commented Dec 10, 2024

Sounds good, everyone! Thank you! I just added the variable as cloud_run_deletion_protection = false

@regisferlima
Copy link
Author

Maybe we could pass it as optional? because when I'm using the module, it always says that deletion_protection should not expected there.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants